Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 24 May 2019 19:44:31 +0100
From:   Will Deacon <will.deacon@arm.com>
To:     Anders Roxell <anders.roxell@linaro.org>
Cc:     peterz@infradead.org, mingo@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking/lockdep: remove print_lock_trace function
Message-ID: <20190524184431.GF9697@fuggles.cambridge.arm.com>
References: <20190516191326.27003-1-anders.roxell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190516191326.27003-1-anders.roxell@linaro.org>
User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) ()
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 16, 2019 at 09:13:26PM +0200, Anders Roxell wrote:
> gcc warns that function print_lock_trace() is unused if
> CONFIG_PROVE_LOCKING isn't set.
> 
> ../kernel/locking/lockdep.c:2820:13: warning: ‘print_lock_trace’ defined
>    but not used [-Wunused-function]
>  static void print_lock_trace(struct lock_trace *trace, unsigned int
>    spaces)
> 
> Rework so we remove the function if CONFIG_PROVE_LOCKING isn't set.
> 
> Fixes: c120bce78065 ("lockdep: Simplify stack trace handling")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  kernel/locking/lockdep.c | 4 ----
>  1 file changed, 4 deletions(-)

Acked-by: Will Deacon <will.deacon@arm.com>

Will