Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp880821ybi; Fri, 24 May 2019 13:03:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+gbQSPAj20CAawnUMUeZV+PaWz2zl39mh+b+y++TPV6ssnnE9Lj01lLa/QasDwD/u9T42 X-Received: by 2002:a63:2107:: with SMTP id h7mr35619391pgh.330.1558728180524; Fri, 24 May 2019 13:03:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558728180; cv=none; d=google.com; s=arc-20160816; b=nh6Pa+qqDOivKm5nHf9c5v4hIiAtMxiDy0SFIJ6w+y3UlzZfNs9tkdaXxOirSjF9Zi ICbsQNEY3SlUzJsAV0R9/G1r/Sdu/R9hV4V8QI0hz82f9HdirckQn/n+5lMw1z5wqDB/ eVGa0NDCGtjQgpF8O2XzboFfZI2jrlzd3RXXM/9onvK1WultICXtUJF29b6LhprL6IVt Cn+NxkrP5Ux6L8jy8LLyXLJyY3higphJtKmYkpoNCiQrNNHVdntGwIMrmmbFqmQ16MIp qRLyN2KWEz4Ro2B9EqipJN+PqCzdy4vfCCVIpIVIK/N3RYxwEnpsv7l6hdUhSo2zCP1X vb6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=7MCwCqfjoZ8d95LiJVDhxA5XYJ+Tj0Dl3KZTdK/joyg=; b=ri3yMyNbPNfD4yWQaCga9syJQT36V+3f/klrAca2uTXQERNrodyByrhxzO7WV6eZzn uArWt5TqT8XmGvrbHTtrLc9KnueSuqpxIHTgUoEnNUy1xh91wyQ+6NeRj6ssqJ20gjdK aDm1hBbE5dvQhdG1DaEJmJxOplFoYq9mG2TuijZMeBLwoOasrX/4dqEaC3yM6KP34zSJ iIzwlWeC2PXP+HWsNQvkdxUmvLCITThpTw/RBF9rLs1wdVA5kIaw+v8CaiatUh6TR+Rv V0f8VfzcBYs2s0kN2eBBJykRCMGjIhPb/yQRZz1DbWe6TaU9y6YQcuR1vaX7GRVZhyqY D+xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@endlessm-com.20150623.gappssmtp.com header.s=20150623 header.b=QPwVNsf1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bf1si5261187plb.49.2019.05.24.13.02.45; Fri, 24 May 2019 13:03:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@endlessm-com.20150623.gappssmtp.com header.s=20150623 header.b=QPwVNsf1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391784AbfEXUB0 (ORCPT + 99 others); Fri, 24 May 2019 16:01:26 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:39917 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391669AbfEXUB0 (ORCPT ); Fri, 24 May 2019 16:01:26 -0400 Received: by mail-qk1-f194.google.com with SMTP id i125so7164966qkd.6 for ; Fri, 24 May 2019 13:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7MCwCqfjoZ8d95LiJVDhxA5XYJ+Tj0Dl3KZTdK/joyg=; b=QPwVNsf12m0Ku3ysuAaKBpvuJ8a3v8BLq8bmJgIiNhWhchdu4WhWI2Rexbzv1BrOv6 vHy80gDcR04xvAP1Ui/TbWCdoaksT+uNOFkBVQpnK4esy54HDNjzBP1RSnGq9fm/uI9u CbqMvLYx7Tv+AwKwCjKX8gnYXnt3zY0V/pAhrQeC97pXJxyb8VyJ2nCUHwG0Oy8Sf9rg hkRl/ADp/emeDS5wlzE/5L/bPxWGmky3EbGtEPeRmWar30IO6KVy39x3QCfwWFMaoOmm tFOqNavX3JitsMfMi9ZnllGycKEgnz6qLYs+mNTJ/SQyYUON+YXSeYb/5iFBt+GXIEC1 ekuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7MCwCqfjoZ8d95LiJVDhxA5XYJ+Tj0Dl3KZTdK/joyg=; b=nouD51xnz0mTVGtfiOteHGzsCSBj7au9rYUK1CnLp2/4Y92GI2ge51AGtETEO3q9ou MNqD7I+SYUL/It2zTi3DyBbySvHa1kYl9QZrBLGDwgF07xv58W2BKOhwdbnCL6QkmpWF tn9ZOIIfx2gkybODC+vCpO/NY+2R0PALkUGI7LaqRWIlyDv6cMynV2CeZBSSFcZs2Vwt +Zs0D1wvBHm8sJrD5lu6iBHQbGp3jrXS328Hm/mTnUo2hmSA0fxdDvpT44JiNPwxNA4E 0zh0bRob2KAlUBrNpgqNzlqA1MrjKnfdGlJH2U1MHXSD49OQdYAP2muQruNpaNxZqNdw AbmA== X-Gm-Message-State: APjAAAUHUP8RFQvBG7cVoNFgObwb9jwgTbSZd6d/FWA4Ev383qF0Lw9g AHkzgCyC904Sgy58rY6akrGyXM38+fiwxDxRPBIC5g== X-Received: by 2002:a0c:d4ee:: with SMTP id y43mr83524858qvh.26.1558728085164; Fri, 24 May 2019 13:01:25 -0700 (PDT) MIME-Version: 1.0 References: <4613f54b-b6ba-c9ad-15ca-e43d440b9f63@gmail.com> In-Reply-To: <4613f54b-b6ba-c9ad-15ca-e43d440b9f63@gmail.com> From: Daniel Drake Date: Fri, 24 May 2019 14:01:14 -0600 Message-ID: Subject: Re: [PATCH v4 03/13] platform/x86: asus-wmi: Increase input buffer size of WMI methods To: Yurii Pavlovskyi Cc: Corentin Chary , Darren Hart , Andy Shevchenko , Chris Chiu , acpi4asus-user , Platform Driver , Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 14, 2019 at 12:54 PM Yurii Pavlovskyi wrote: > > The asus-nb-wmi driver is matched by WMI alias but fails to load on TUF > Gaming series laptops producing multiple ACPI errors in the kernel log. > > The input buffer for WMI method invocation size is 2 dwords, whereas > 3 are expected by this model. > > FX505GM: > .. > Method (WMNB, 3, Serialized) > { > P8XH (Zero, 0x11) > CreateDWordField (Arg2, Zero, IIA0) > CreateDWordField (Arg2, 0x04, IIA1) > CreateDWordField (Arg2, 0x08, IIA2) > Local0 = (Arg1 & 0xFFFFFFFF) > ... > > Compare with older K54C: > ... > Method (WMNB, 3, NotSerialized) > { > CreateDWordField (Arg2, 0x00, IIA0) > CreateDWordField (Arg2, 0x04, IIA1) > Local0 = (Arg1 & 0xFFFFFFFF) > ... > > Increase buffer size to 3 dwords. No negative consequences of this change > are expected, as the input buffer size is not verified. The original > function is replaced by a wrapper for a new method passing value 0 for the > last parameter. The new function will be used to control RGB keyboard > backlight. > > Signed-off-by: Yurii Pavlovskyi Reviewed-by: Daniel Drake