Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1291300ybi; Fri, 24 May 2019 22:05:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkR/XX6QsxHJ7HXHbaYLH9fJ6j9cc7EOGHtZGX+vsQqHyzw68An/2Q2fM428J//dklU3OH X-Received: by 2002:a17:90a:a593:: with SMTP id b19mr13975681pjq.31.1558760725680; Fri, 24 May 2019 22:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558760725; cv=none; d=google.com; s=arc-20160816; b=eeu4bhxDS+4ot4NPqyIfMZ3yqvIGfvaaU2JUkCLzYFW2halV24zqGoi3dMLbk0z8Ht QiOWtSgqiQ0ejmFNhGQM+aiA86H8P5Bub7rgQ4u2enx5PQ4pZNYSsqwasrUelVXjLATS RuqxjCbqFIxV5PMgzSyX+Jr1AhGMoaYuGV61TPZf1NCvkU3PBa0l5vuzuiy8PfaDx4mR U3FO7oruZO6axA+98QWO2Y4HxKDVq6ZHbh3k5P0ECoYoUxyPcpxyanab6B+U99bslZvY umZXfxTG0Ps2N1ccbej8izVYaW9tergaiossCmP7k6I8RaQIabNA3f1l/HCH20RU8iCW 23lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GtTzaHL3sf+gyHaSPExJ/hQuYmSYZL+uUSM4FTfINNM=; b=u8sbCdBae+zyKALpNl8TydRxwR91LrxTIRaSoIN2y4B5CL9YtYRE9Mdo6LyaqrXco7 8qRAiOfdVz8JWo/mr2D9/JTnRPY5WVH7iLL9pYP4ginPedF4Kbk5pcdnSb701M8S2WAA 7VtePVjRnEprJFaV8FBoJnE43caFORleONxBuFFhJrqWqOPAlKuGhpD4WhFDggkZzrM8 fjWTCu/dxLsQ3NT1rMcl1QitG9Fa2kE8VOzjR38lkVM4EwMGX4a8a5I8dzsdCfBssjZy w/KBxMBYXi5SIe+O1MRH/MeJLC1oe9x0FTrpUfAuGudyLfO2qApwh5E+rlNARR6OaSkc IF3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=00FgJh01; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si6287054pgd.64.2019.05.24.22.04.20; Fri, 24 May 2019 22:05:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=00FgJh01; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbfEYFAV (ORCPT + 99 others); Sat, 25 May 2019 01:00:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:46366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfEYFAV (ORCPT ); Sat, 25 May 2019 01:00:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1488B2177E; Sat, 25 May 2019 05:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558760420; bh=mIXbDXcQPMJSc4UESXKNywctOSB6Moa7tm6Jt46hGR4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=00FgJh01/Thls1CggdEZBj8yQBkONkK7KKarlpioeuDiFOyer6WSHGtYbOSnyrJ60 tHdAcyGob9MFtufyHhv2JzLmHzs4vgpLTUtssIJEZ39/jF1EUOI8wN9wbtFPPR0FaK DQE+bvaZ6bUXPRsbh2hnM2kBUCyZPQi+EfUR64ok= Date: Sat, 25 May 2019 07:00:17 +0200 From: Greg KH To: Simon =?iso-8859-1?Q?Sandstr=F6m?= Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000 Message-ID: <20190525050017.GA18684@kroah.com> References: <20190524203058.30022-1-simon@nikanor.nu> <20190524203058.30022-3-simon@nikanor.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190524203058.30022-3-simon@nikanor.nu> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 10:30:58PM +0200, Simon Sandstr?m wrote: > Fixes build errors: > > ERROR: "mfd_remove_devices" [kpc2000.ko] undefined! > ERROR: "uio_unregister_device" [kpc2000.ko] undefined! > ERROR: "mfd_add_devices" [kpc2000.ko] undefined! > ERROR: "__uio_register_device" [kpc2000.ko] undefined! > > Signed-off-by: Simon Sandstr?m > --- > drivers/staging/kpc2000/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig > index c463d232f2b4..5188b56123ab 100644 > --- a/drivers/staging/kpc2000/Kconfig > +++ b/drivers/staging/kpc2000/Kconfig > @@ -3,6 +3,8 @@ > config KPC2000 > bool "Daktronics KPC Device support" > depends on PCI > + select MFD_CORE > + select UIO > help > Select this if you wish to use the Daktronics KPC PCI devices > This is already in linux-next (in a different form), are you sure you are working against the latest kernel tree? thanks, greg k-h