Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1856762ybi; Sat, 25 May 2019 10:21:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwt2pLsU0HafKhOdkv6E6HK1qXbo39wPgm0m4jzncqjeUVADU+S/6LbGZAFLQAaWF+4KirQ X-Received: by 2002:a62:e10f:: with SMTP id q15mr27679912pfh.56.1558804894616; Sat, 25 May 2019 10:21:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558804894; cv=none; d=google.com; s=arc-20160816; b=fwFKkgl9o8qRIiyKEcvHDdVed0Woqf2KJ847BFymhCTZqAevu1vwJEvbOAHf+UakYk ++rgUrLskuK6vC1mKvosSOYsn467Yhy50twf2xwUQrWO5+Cym197Qa9WZogrlxBO77zy wtojEffI5b9PsXlSvUrMIV61BnH1oJNTMm9k9yMKY0czcp27TEFq49rYmS723EzQegUc teh89VJbdhnrP0cbT2FD5zLSFYxQxEo8ZSJ7noiD+Snvtal7ZHnx18ipQz6rgifxm7Xq D1S5ZFuOpiJEnAnYa7Mf0+CKqYNJXEzGWWz9l61edHzP3usBF/dJBELoAVo2Q3I8FTIU OltQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature; bh=M6D54Y9cAdwUjftrKOdf9/RVXWKvemPtHhP4qHuwDPc=; b=W2TWib8VnquXfpsIwq7a6Zve7zBWZI5N+cK0xVZqi5uhBSO1HVbZCHa49+sWhnZH62 eeDWXYpAOXr8Vl+x0ZmyR9D6k+f3d/343KnP7uELLrVXrc2NWpKuj3fXmxpxU+hta97v v0ofWit+vPYCXqYyxmTjwuwxYOmNntynahDMODnSPd1GfP5y1ekwMNPTPiMsAWPDEUPy jsUtcnpgruSXQf7a0w7UIrpT9lG9p/7ESdb60dnWrfu7ELOvd4rXWdTcw36bTl+qU5sF 1M7vC2UTvSoJYeHZ6gDgI+edlkffoF7JI45PJ6QR5PFN434qZcLLpjahUdoWjZDyGAuA GAxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oQzOmXyi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si8721036plt.101.2019.05.25.10.21.19; Sat, 25 May 2019 10:21:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oQzOmXyi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727163AbfEYRUH (ORCPT + 99 others); Sat, 25 May 2019 13:20:07 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:43035 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfEYRUH (ORCPT ); Sat, 25 May 2019 13:20:07 -0400 Received: by mail-pf1-f193.google.com with SMTP id c6so7159341pfa.10 for ; Sat, 25 May 2019 10:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=M6D54Y9cAdwUjftrKOdf9/RVXWKvemPtHhP4qHuwDPc=; b=oQzOmXyiswoQAHAKdEwj0INIkSyCBfdhsp23Y8yvpbSv8OJ2y/xrSB3fNaGfHTEsPE W494Lrnnzdh6Pc5FTSRe2bSKc3BFDH80azlAPda+MXGuMa/F+kilgPgcAX4czQo+zxvB hBHLzWpxzkarYsDEMelf7pCRrYIeYMZ9TPPWuGytLZci/MZU8ob3V4HFNUIZrS6t3b9q lR5iMBZ9pxPp8ZCSK8t31Ia/Mwd6LEjyTla4/g+T6LEvGx61Lo2vtisNEmwtlQVwU8Ej euRNnaTfXzldXKhMeAeihdQCFngYhzDGMutFTVlrAKwsot0DAccO2/xg51hL3PARDTjl KzkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=M6D54Y9cAdwUjftrKOdf9/RVXWKvemPtHhP4qHuwDPc=; b=qg8b0c4SqUnb0n9mLaFii6W/FuqwBVCafpqX079ojNrJUCtzm2HeJFjJcY8ErbL7el G//YoVVo1B9x/c6cAeE1ZC1Hh0Owe7NpgHENNMmiu3LJSEXTvi8BlGr6b6ypqe61AuIM thGOC0B9ixynBqGM/xY+5SHsQ5Xq9ZK0ailk8L1tTDZAiaZMVsnaDDGiKSqrm/eSmxVt 5jZPhrdEUkJnmrcVnNahRK3rwY3ArVuq3M6ZRXVs9uwev9+gqUUbtxjnl8qnCiUJ3kcO 3gjrFJ7DXw9xjDkX5KO3pBkNvFyRbKwRJjXfhKNYt++Sptrif1+VRCMpWmmOuwq1JVwj CJZA== X-Gm-Message-State: APjAAAUWLPXs7/iDNq/yw5g3J9ZnWOpPZzAZg4DKQ6d1wNNFeZslEwjw pZU9jpBs/hRHZQaet9sJhB4= X-Received: by 2002:a63:c24c:: with SMTP id l12mr114354053pgg.173.1558804806540; Sat, 25 May 2019 10:20:06 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.92.73]) by smtp.gmail.com with ESMTPSA id m9sm6861513pgd.23.2019.05.25.10.20.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 May 2019 10:20:05 -0700 (PDT) Date: Sat, 25 May 2019 22:50:00 +0530 From: Hariprasad Kelam To: Greg Kroah-Hartman , Hariprasad Kelam , Puranjay Mohan , Colin Ian King , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: rtl8723bs: hal: fix warning possible condition with no effect (if == else) Message-ID: <20190525172000.GA18730@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org this patch fixes below coccicheck warning ./drivers/staging/rtl8723bs/hal/odm_DIG.c:499:1-3: WARNING: possible condition with no effect (if == else) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_DIG.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c index d7d87fa..70d98c5 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c @@ -496,13 +496,8 @@ void odm_DIGInit(void *pDM_VOID) /* To Initi BT30 IGI */ pDM_DigTable->BT30_CurIGI = 0x32; - if (pDM_Odm->BoardType & (ODM_BOARD_EXT_PA|ODM_BOARD_EXT_LNA)) { - pDM_DigTable->rx_gain_range_max = DM_DIG_MAX_NIC; - pDM_DigTable->rx_gain_range_min = DM_DIG_MIN_NIC; - } else { - pDM_DigTable->rx_gain_range_max = DM_DIG_MAX_NIC; - pDM_DigTable->rx_gain_range_min = DM_DIG_MIN_NIC; - } + pDM_DigTable->rx_gain_range_max = DM_DIG_MAX_NIC; + pDM_DigTable->rx_gain_range_min = DM_DIG_MIN_NIC; } -- 2.7.4