Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Huang\, Ying" <ying.huang@intel.com>
To:     Josef Bacik <josef@toxicpanda.com>
Cc:     kernel test robot <rong.a.chen@intel.com>,
        David Sterba <dsterba@suse.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        "lkp\@01.org" <lkp@01.org>, LKML <linux-kernel@vger.kernel.org>,
        Qu Wenruo <wqu@suse.com>
Subject: Re: [LKP] [btrfs]  302167c50b:  fio.write_bw_MBps -12.4% regression
References: <20190203081802.GD10498@shao2-debian>
        <87h8alqong.fsf@yhuang-dev.intel.com>
        <87o94dl6pg.fsf@yhuang-dev.intel.com>
        <874l5k9tx2.fsf@yhuang-dev.intel.com>
        <20190524143558.mem7gircjjmut54f@MacBook-Pro-91.local>
Date:   Mon, 27 May 2019 08:38:54 +0800
In-Reply-To: <20190524143558.mem7gircjjmut54f@MacBook-Pro-91.local> (Josef
        Bacik's message of "Fri, 24 May 2019 10:36:00 -0400")
Message-ID: <87r28k91ep.fsf@yhuang-dev.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Josef Bacik <josef@toxicpanda.com> writes:

> On Fri, May 24, 2019 at 03:46:17PM +0800, Huang, Ying wrote:
>> "Huang, Ying" <ying.huang@intel.com> writes:
>> 
>> > "Huang, Ying" <ying.huang@intel.com> writes:
>> >
>> >> Hi, Josef,
>> >>
>> >> kernel test robot <rong.a.chen@intel.com> writes:
>> >>
>> >>> Greeting,
>> >>>
>> >>> FYI, we noticed a -12.4% regression of fio.write_bw_MBps due to commit:
>> >>>
>> >>>
>> >>> commit: 302167c50b32e7fccc98994a91d40ddbbab04e52 ("btrfs: don't end
>> >>> the transaction for delayed refs in throttle")
>> >>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git pending-fixes
>> >>>
>> >>> in testcase: fio-basic
>> >>> on test machine: 88 threads Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz with 64G memory
>> >>> with following parameters:
>> >>>
>> >>> 	runtime: 300s
>> >>> 	nr_task: 8t
>> >>> 	disk: 1SSD
>> >>> 	fs: btrfs
>> >>> 	rw: randwrite
>> >>> 	bs: 4k
>> >>> 	ioengine: sync
>> >>> 	test_size: 400g
>> >>> 	cpufreq_governor: performance
>> >>> 	ucode: 0xb00002e
>> >>>
>> >>> test-description: Fio is a tool that will spawn a number of threads
>> >>> or processes doing a particular type of I/O action as specified by
>> >>> the user.
>> >>> test-url: https://github.com/axboe/fio
>> >>>
>> >>>
>> >>
>> >> Do you have time to take a look at this regression?
>> >
>> > Ping
>> 
>> Ping again.
>> 
>
> This happens because now we rely more on on-demand flushing than the catchup
> flushing that happened before.  This is just one case where it's slightly worse,
> overall this change provides better latencies, and even in this result it
> provided better completion latencies because we're not randomly flushing at the
> end of a transaction.  It does appear to be costing writes in that they will
> spend more time flushing than before, so you get slightly lower throughput on
> pure small write workloads.  I can't actually see the slowdown locally.
>
> This patch is here to stay, it just shows we need to continue to refine the
> flushing code to be less spikey/painful.  Thanks,

Thanks for detailed explanation.  We will ignore this regression.

Best Regards,
Huang, Ying