Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3478755ybi; Mon, 27 May 2019 00:24:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTFokliqOP5/NMCMFwkL6lRSjpAk1I1nSVzgmue9RznnM3xwnYP4+sieEU2N/S907wwfKs X-Received: by 2002:a62:e217:: with SMTP id a23mr89425408pfi.128.1558941882117; Mon, 27 May 2019 00:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558941882; cv=none; d=google.com; s=arc-20160816; b=Cyo+z5QpXoWW8z4ootpaFF1n/PC/enlairFCfFADA8dzO6d+5O25ExQcukS3aYqg1v QrkKsTUrAE/G5w5z+pihB4vBww3mEYvLgTpwcxvCZ6Uk5yb6qld4NrfrZbgK1CFC4e3h vZfChRBDHIP80kY//6PLT6qBHLkMArIv/5eo1U0hiW9v7OY5P6iriAyZaMev/qFoSkvg eXeK5EkkmfKjXh3RmFxMDCqvWWVYHITSQZ8gFuNHvDbO0wcfdBP0Ld/L6x4/9MiLA8rx +JJsSfokB0iCvsV9R+45z8hbN9fIjjTJ6sncxLQqENYjshh/3lniNqFJs+hn9S/fiSGR u4Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=Errqcpif3MNk2kJb3yQfhTKLSnUjwjop832gHku4d3I=; b=IC2DJvXRRltHYzOCtNll21Iw6UfGlQX3evPiu6xyeZ9yDwUa8Qyby6FxKY2QXywxQ6 zVLgoWrP8/1UWUYo6T0G87DdCpmUFR/PePROskP+lIuR5VeeaT5XZziN5FVgZMGGpjzc ASwTFt4dr6UxFQE3+NsfKPUge9CNm7x2ZKd9jdo+UPWYaDo8MvFy5eAsqqg8ZBi3QNqx crPmbFVe1AyciT9GD47x8ASJdrx6rRR+6DhPtTg6n7ev4yyvr03KOW59MD07QTZ0v9Ge d1/fNhRRfBncaO1wi2Ujpk1Fw55iLHzxdSB4Q7LxrNjDRzYgOnCZDw4ezMcDKmpaukdN /umA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Q1LE5Gpe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si16467290pgs.335.2019.05.27.00.24.25; Mon, 27 May 2019 00:24:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Q1LE5Gpe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbfE0HWS (ORCPT + 99 others); Mon, 27 May 2019 03:22:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:60536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfE0HWS (ORCPT ); Mon, 27 May 2019 03:22:18 -0400 Received: from localhost (unknown [84.241.203.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B26B216FD; Mon, 27 May 2019 07:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558941738; bh=CxB+YRQgE6cg6pK9JoVm/avHUmPTbThAgAVMMNqahMQ=; h=Date:From:To:Subject:References:In-Reply-To:From; b=Q1LE5GpeWeMfjI+hQTRVaCT6KkOhR4yTvtSxlGlomgJOpBdtnKVWXl/IoF5xSw+Xb lIYZ5Lhm2x1hJ5Fxz5OXkIluhD211azcL8pdZtwteQd5ZUl3NmbY56G5/UzV3ndz+Q D7a3oyLH+7yUgzfhkv2zHrBs0yJZif7v2zhgNbek= Date: Mon, 27 May 2019 09:22:14 +0200 From: Greg Kroah-Hartman To: LKML , Intel Graphics Development , DRI Development , Daniel Vetter , Nicolas Pitre , Martin Hostettler , Adam Borowski , Mikulas Patocka Subject: Re: [PATCH 04/33] vt: More locking checks Message-ID: <20190527072214.GB7997@kroah.com> References: <20190524085354.27411-1-daniel.vetter@ffwll.ch> <20190524085354.27411-5-daniel.vetter@ffwll.ch> <20190527070858.GJ21222@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190527070858.GJ21222@phenom.ffwll.local> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 27, 2019 at 09:08:58AM +0200, Daniel Vetter wrote: > On Fri, May 24, 2019 at 10:53:25AM +0200, Daniel Vetter wrote: > > I honestly have no idea what the subtle differences between > > con_is_visible, con_is_fg (internal to vt.c) and con_is_bound are. But > > it looks like both vc->vc_display_fg and con_driver_map are protected > > by the console_lock, so probably better if we hold that when checking > > this. > > > > To do that I had to deinline the con_is_visible function. > > > > Signed-off-by: Daniel Vetter > > Cc: Greg Kroah-Hartman > > Cc: Nicolas Pitre > > Cc: Martin Hostettler > > Cc: Adam Borowski > > Cc: Daniel Vetter > > Cc: Mikulas Patocka > > Hi Greg, > > Do you want to merge this through your console tree or ack for merging > through drm/fbdev? It's part of a bigger series, and I'd like to have more > testing with this in our trees, but also ok to merge stand-alone if you > prefer that. It's just locking checks and some docs. > > Same for the preceeding patch in this series here. For all of these, please take them through your tree(s): Acked-by: Greg Kroah-Hartman