Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/3] KVM: X86: Implement PV sched yield hypercall
To:     Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <1558953255-9432-1-git-send-email-wanpengli@tencent.com>
 <1558953255-9432-3-git-send-email-wanpengli@tencent.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <0b8525d8-e26b-e4df-508d-b6a4d9c06a76@redhat.com>
Date:   Mon, 27 May 2019 13:53:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1558953255-9432-3-git-send-email-wanpengli@tencent.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 27/05/19 12:34, Wanpeng Li wrote:
> +	rcu_read_lock();
> +	map = rcu_dereference(kvm->arch.apic_map);
> +	target = map->phys_map[dest_id]->vcpu;
> +	rcu_read_unlock();
> +
> +	kvm_vcpu_yield_to(target);

This needs to check that map->phys_map[dest_id] is not NULL.

Paolo