Return-Path: <linux-kernel-owner+willy=40w.ods.org-S965191AbVKPC4l@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965191AbVKPC4l (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 15 Nov 2005 21:56:41 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965189AbVKPC4l
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 15 Nov 2005 21:56:41 -0500
Received: from gateway-1237.mvista.com ([12.44.186.158]:5619 "EHLO
	hermes.mvista.com") by vger.kernel.org with ESMTP id S965183AbVKPC4l
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Nov 2005 21:56:41 -0500
Date: Tue, 15 Nov 2005 19:57:14 -0700
From: "Mark A. Greer" <mgreer@mvista.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrey Volkov <avolkov@varma-el.com>, lm-sensors@lm-sensors.org,
       linux-kernel@vger.kernel.org, "Mark A. Greer" <mgreer@mvista.com>
Subject: Re: [PATCH 1/1] Added support of ST m41t85 rtc chip
Message-ID: <20051116025714.GK5546@mag.az.mvista.com>
References: <4378960F.8030800@varma-el.com> <20051115215226.4e6494e0.khali@linux-fr.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051115215226.4e6494e0.khali@linux-fr.org>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1394
Lines: 38

Hi Jean,

On Tue, Nov 15, 2005 at 09:52:26PM +0100, Jean Delvare wrote:

<snip>

> First, a question. Can't you merge the M41T85 support into the m41t00
> driver?
> 
> Mark, care to comment on that possibility, and/or on the code itself?

Sure.

I wrestled with the ST website for the m41t85 datasheet but lost so I
I can only guess from the patch.  The drivers do look very similar.
It looks like the m41t85 is basically a m41t00 with an alarm (watchdog
timer never used AFAICT).  Also there are some differences in register
offsets and [maybe] some minor differences within the registers but
nothing that serious.

I think we can combine the two into an m41txx.c and pass the exact type
in via platform_data--that would be the correct mechanism, right?
The platform_data could also be used to seed the correct SQW freq and
eliminate all the Kconfig noise.

Comments?

As for Jean's and Andrew's comments about the driver, they seem valid
to me and should be addressed.  In Andrey's defense, many of them are my
fault.  Once there is a consensus on the merging m41t00 & m41t85
question, I'll try to get a fixed up patch within a couple weeks.

Mark
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/