Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 May 2019 00:46:18 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     "Zhao, Yakui" <yakui.zhao@intel.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
        Jason Chen CJ <jason.cj.chen@intel.com>
Subject: Re: [PATCH v6 4/4] x86/acrn: Add hypercall for ACRN guest
Message-ID: <20190527224618.GB8209@cz.tnic>
References: <1556595926-17910-1-git-send-email-yakui.zhao@intel.com>
 <1556595926-17910-5-git-send-email-yakui.zhao@intel.com>
 <20190515073715.GC24212@zn.tnic>
 <b8210e0e-bdf2-3e17-ce9a-d7a3ca0e6672@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b8210e0e-bdf2-3e17-ce9a-d7a3ca0e6672@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 27, 2019 at 10:57:09AM +0800, Zhao, Yakui wrote:
> I refer to the Xen/KVM hypercall to add the ACRN hypercall in one separate
> header.

And?

> The ACRN hypercall is defined in one separate acrn_hypercall.h and can be
> included explicitly by the *.c that needs the hypercall.

Sure but what else will need the hypercall definition except stuff which
already needs acrn.h? I.e., why is the separate header needed?

> The hypercall will be used in driver part. Before the driver part is added,
> it seems that the defined ACRN hypercall functions are not used.
> Do I need to add these functions together with driver part?

Yes, send functions together with the stuff which uses them pls.

Thx.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply. Srsly.