Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1558953255-9432-1-git-send-email-wanpengli@tencent.com>
 <1558953255-9432-3-git-send-email-wanpengli@tencent.com> <0b8525d8-e26b-e4df-508d-b6a4d9c06a76@redhat.com>
In-Reply-To: <0b8525d8-e26b-e4df-508d-b6a4d9c06a76@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Tue, 28 May 2019 08:54:14 +0800
Message-ID: <CANRm+CxEa2Z1Ob=pEM03AvryHUfjg-MEc75w5_a-wHzrb9NtvQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] KVM: X86: Implement PV sched yield hypercall
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 27 May 2019 at 19:54, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 27/05/19 12:34, Wanpeng Li wrote:
> > +     rcu_read_lock();
> > +     map = rcu_dereference(kvm->arch.apic_map);
> > +     target = map->phys_map[dest_id]->vcpu;
> > +     rcu_read_unlock();
> > +
> > +     kvm_vcpu_yield_to(target);
>
> This needs to check that map->phys_map[dest_id] is not NULL.

Fixed in v2, thanks for the quick review. :)

Regards,
Wanpeng Li