Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4541205ybi; Mon, 27 May 2019 21:05:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwplr212TgKkL5D8FsVxTFqgGvoyCj9sRiWo+k2cgAf1q7hbTUC1rmeu0oU/sWPsVcUmuuB X-Received: by 2002:a62:5a47:: with SMTP id o68mr113928249pfb.149.1559016331628; Mon, 27 May 2019 21:05:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559016331; cv=none; d=google.com; s=arc-20160816; b=ysdS6o1hbvMACXbfM1QktCOjPqfx4UT6yQN0M2WI24NyMtsmsDtNFVXq0vCwRbI3PD 4gIdqibiYfI8s0xPJbi6PrR19DL0qG9ulO0QItG0aDjGLlAmI2t5tCqroeWvIQs1wkKZ 5zsEPIWO77t12KNR9sCl1YHQWxkT2jEcRsmtIjUEe1d0HvN4xzQ0Zp+n1HxvRiMD5GI/ Af2hEIsYc0EC7e5WREuWKdOZ06Zrno2YKC5JotUqqk7XbaMs02qOcO9ixN54+VK7ZvMw IG0I7BoV5ZoUv0//GPC5ZC8BKONVGKRzximI4ED1RRYty6mLVQLfep/9Gvc726qrrHjT iTwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Lu+gu+UrmHVEAqE4CQTX/IfVmDfuMo8fzI2VWG05QVA=; b=WFnB8bk5If8OJuEE3/7sF5SMRohYbxI/MkFB/w7ZBz8pMUyJdtYcFHVIeRRikeHOx9 VH8UtQRbroQMppmTyTXMbWbl9gcOn0u+HUkzS+aLlNiwY6o1xAXxLxAtXxax9IJpz1A9 oX4u4H+S6n9paSj0lhxWEWNUC6V9nycXKJJvyITJh6FbsGdMJH69vyxOZ46cWK5E7yTC 8/9mSs1zKHMoby8+wtsT9w/8OCpe04adlu/5fsLsQCvhFvjzy33Q5ruW7V7kYqLFoJPQ Hy/4TAuDDSp9QYhAhccwqE0nPt4jiV/v9D8U1/ndmJyatIgJDuPjPbTxairW2DpSYmL9 pOHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@anastas.io header.s=mail header.b=Jn2AxMt4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=anastas.io Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 22si170435pgq.134.2019.05.27.21.05.15; Mon, 27 May 2019 21:05:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@anastas.io header.s=mail header.b=Jn2AxMt4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=anastas.io Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbfE1EDX (ORCPT + 99 others); Tue, 28 May 2019 00:03:23 -0400 Received: from alpha.anastas.io ([104.248.188.109]:37331 "EHLO alpha.anastas.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726930AbfE1EDV (ORCPT ); Tue, 28 May 2019 00:03:21 -0400 Received: from authenticated-user (alpha.anastas.io [104.248.188.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alpha.anastas.io (Postfix) with ESMTPSA id 434DE7F8F7; Mon, 27 May 2019 23:03:20 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anastas.io; s=mail; t=1559016201; bh=JsmM3TF8YlXJ0OlLlUbqQr2/zPIZK0XaaIlAJ070/mg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jn2AxMt42ZCz3e1YKcBCeKXmAjA3F7ku2HLuLBPH//ysiYdMmgRPnSQe2syp/9j2w GMngJSrqbOT4/K+dsUFKyBNfBHmxMkPHWxKShiEzelecrfC8Ee/CpRNSHlPTmK5O7H bDN6xC9W3NrIgu9+uBcsg8ItBDh2pj/xzf1I9idZqaoKjumIhNcvk0StHI9kM99+EK IYp/kQT3q0YsmSWXY5fe+4BGs5yTFL6zf1sxmeLxIT0GjcW732ogRM4GsZhkDNotjv DLYiwPB6F5BaSsh1C1/MwSnOIFMTIiwwbKl11//3hYBC1rKba95blgJw6BcpViKEWh d7KNVaKggOILg== From: Shawn Anastasio To: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: bhelgaas@google.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, sbobroff@linux.ibm.com, xyjxie@linux.vnet.ibm.com, rppt@linux.ibm.com, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] PCI: Introduce pcibios_ignore_alignment_request Date: Mon, 27 May 2019 23:03:11 -0500 Message-Id: <20190528040313.35582-2-shawn@anastas.io> In-Reply-To: <20190528040313.35582-1-shawn@anastas.io> References: <20190528040313.35582-1-shawn@anastas.io> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Introduce a new pcibios function pcibios_ignore_alignment_request which allows the PCI core to defer to platform-specific code to determine whether or not to ignore alignment requests for PCI resources. The existing behavior is to simply ignore alignment requests when PCI_PROBE_ONLY is set. This is behavior is maintained by the default implementation of pcibios_ignore_alignment_request. Signed-off-by: Shawn Anastasio --- drivers/pci/pci.c | 9 +++++++-- include/linux/pci.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 8abc843b1615..8207a09085d1 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5882,6 +5882,11 @@ resource_size_t __weak pcibios_default_alignment(void) return 0; } +int __weak pcibios_ignore_alignment_request(void) +{ + return pci_has_flag(PCI_PROBE_ONLY); +} + #define RESOURCE_ALIGNMENT_PARAM_SIZE COMMAND_LINE_SIZE static char resource_alignment_param[RESOURCE_ALIGNMENT_PARAM_SIZE] = {0}; static DEFINE_SPINLOCK(resource_alignment_lock); @@ -5906,9 +5911,9 @@ static resource_size_t pci_specified_resource_alignment(struct pci_dev *dev, p = resource_alignment_param; if (!*p && !align) goto out; - if (pci_has_flag(PCI_PROBE_ONLY)) { + if (pcibios_ignore_alignment_request()) { align = 0; - pr_info_once("PCI: Ignoring requested alignments (PCI_PROBE_ONLY)\n"); + pr_info_once("PCI: Ignoring requested alignments\n"); goto out; } diff --git a/include/linux/pci.h b/include/linux/pci.h index 4a5a84d7bdd4..47471dcdbaf9 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1990,6 +1990,7 @@ static inline void pcibios_penalize_isa_irq(int irq, int active) {} int pcibios_alloc_irq(struct pci_dev *dev); void pcibios_free_irq(struct pci_dev *dev); resource_size_t pcibios_default_alignment(void); +int pcibios_ignore_alignment_request(void); #ifdef CONFIG_HIBERNATE_CALLBACKS extern struct dev_pm_ops pcibios_pm_ops; -- 2.20.1