Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4687849ybi; Tue, 28 May 2019 00:33:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqyt8SLpP1bGzkB8xe1CW4MbdKxcwD9tnozq6qV8fvogLdmyu3RNJ+49FeuL7WUcKZkKWLlQ X-Received: by 2002:a17:902:9343:: with SMTP id g3mr132002482plp.260.1559028786519; Tue, 28 May 2019 00:33:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559028786; cv=none; d=google.com; s=arc-20160816; b=FvHQLTeR4GxrCn8vU6j6hy6S8jzqJEgiPEcxSBjU3qupwrC3JliJZBQXbEefhgkCQt aM3HDgLXqpvonNS2GM6eorC54ubtdOMA7UbgfLJ7UqJ7Z/F8fAfe21fR+kwuKylJnQSb zTBORM81PFJuzz0L/TS/IAS5+SE9xBXr0QEyh0iAZDU+aWLvVRpt6ej46Bw/M4NZfXle +//M7spId3H4rD+vrXtDxD/v4g6aP/II16mmZrAEkNGUOd8gi07RGhtCGux9BHpWxAE6 rHtx+1kYjp1AiwnwzpfZbGqAUmQBtOAEnMYdQeMN+Fmd1ZtwdzPUE9rdoPb2TudmJ3Rr QA5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=liX278HTgn3dzodp7H0O3yv5Xch4o5IxEkhO3Idcuvw=; b=a7kMnsV1SEad0Ok8bCOX1ahSRhO/6QRJUhyxtzPM2jW+YAj7mfJi9FgCEvrm9wLgxk EMajzFFy0DoAOniTY9391HgAb2aIL7tIh+yWLZU6plT71xd6rnxUCm4CwqZZQAOtd7cx vPow/n1n824foJ9Rk9pR1iLNfSLNy0dWhrSVOetayqSJY1lWJGxGF7wct5mtlJ3bRCCP I2PJwkG96lBWfyp7Sh15ZrZOWfYopSxcN/qdfc8TSzZS0wQ/EbEMam2bZ68wgI4PUSIp 0+do0FgtIvFmQZdywuOKGz3dGmHgSZDdzpPgKGQGoqv33l1THTLLIRNIGFN4Z/8/crQY QHHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xof57xMe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si2259054pjt.61.2019.05.28.00.32.50; Tue, 28 May 2019 00:33:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xof57xMe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727668AbfE1Hal (ORCPT + 99 others); Tue, 28 May 2019 03:30:41 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:44687 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727644AbfE1Hak (ORCPT ); Tue, 28 May 2019 03:30:40 -0400 Received: by mail-qk1-f194.google.com with SMTP id w187so10775581qkb.11 for ; Tue, 28 May 2019 00:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=liX278HTgn3dzodp7H0O3yv5Xch4o5IxEkhO3Idcuvw=; b=Xof57xMef9rhMVvwdzWqgl8c8PWB/Qq5WaAyj1db7xil+fDCj2i2m2YnoW8pKwTFyW 2fV5WVtAWhMVaj64Iuj3Xg8EqCSIHF9C1lbxhu3ktohEZLkh788n0+WGOtLwsRx5rSSB idqXNx8jf21nLRjVkPZziJlecnNAnwLPmW96STeBbUTLipuKTqsP7RhQL0Ob3lS65mkx UfHomb1WgXBlgs+mcjx1y7MMHVGLMi62Y+rgLWH1eZYzKN7d8r65fCXeTVeX7ZVuzXCK RD9+LjBiqfsMx6BBjE4DmFkIMgoU4pUkbXkfAC55Nl4lss1Qn+wXSgeO8/o6OXFjcjzP qjew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=liX278HTgn3dzodp7H0O3yv5Xch4o5IxEkhO3Idcuvw=; b=j2sTHYpUkxjWgCFnfdZuT4vrp3SgqHkpw/Csh6SvTrGTA8WC5bD+XQhbktQky8VVS9 lbe/0Ih8HiwBQ4y2i1ht6zfSmMR8I3+dhYXOoMYOVWxuaps9sNmk8wPGFl3Zy8JUk+d3 JNI312o7l6D9vrOjz9hDioTH5BlQw9CPH+gclca6o9UzNALvlH9h6KP87h2pe2OopiLr 6VM5Gb3SXNZ3iOQ2qyx0hyWP6mbFcjPp3I2aR0STE401hBnToOyQvyLC7/LOJnyh1JRE mDH4zDm2ijnxMvs/g01iisyl5wIeAzck8tLg06kByqFpBn0BdlU+b8HxDyYOOpbWLLbU AcAw== X-Gm-Message-State: APjAAAVdQLafXTbfcZuXPyLoBa4qsLJQvlKziB+Wh2BwYaCbCsrA8ZBV oxa2j3oN2EhASjbOSfhQa9uAAY/AGnhDIatTj+ctGA== X-Received: by 2002:a37:502:: with SMTP id 2mr3621845qkf.93.1559028639303; Tue, 28 May 2019 00:30:39 -0700 (PDT) MIME-Version: 1.0 References: <20190527115830.15836-1-benjamin.gaignard@st.com> <1e4c4cbf-869e-8b6a-a1d6-cc7dccb2515a@st.com> In-Reply-To: <1e4c4cbf-869e-8b6a-a1d6-cc7dccb2515a@st.com> From: Benjamin Gaignard Date: Tue, 28 May 2019 09:30:28 +0200 Message-ID: Subject: Re: [PATCH] drm/stm: ltdc: restore calls to clk_{enable/disable} To: Philippe CORNU Cc: Benjamin GAIGNARD , Yannick FERTRE , "airlied@linux.ie" , "daniel@ffwll.ch" , Alexandre TORGUE , "linux-arm-kernel@lists.infradead.org" , "linux-stm32@st-md-mailman.stormreply.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le lun. 27 mai 2019 =C3=A0 14:28, Philippe CORNU a = =C3=A9crit : > > Hi Benjamin, > > Many thanks for this fix (and more generally for pushing STM patches on > misc :-) > > Acked-by: Philippe Cornu Applied on drm-misc-next, sorry for the mistake. Benjamin > > Philippe :-) > > On 5/27/19 1:58 PM, Benjamin Gaignard wrote: > > From: Benjamin Gaignard > > > > Restore calls to clk_{enable/disable} deleted after applying the wrong > > version of the patch > > > > Fixes: fd6905fca4f0 ("drm/stm: ltdc: remove clk_round_rate comment") > > > > Signed-off-by: Benjamin Gaignard > > --- > > drivers/gpu/drm/stm/ltdc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > > index ae2aaf2a62ee..ac29890edeb6 100644 > > --- a/drivers/gpu/drm/stm/ltdc.c > > +++ b/drivers/gpu/drm/stm/ltdc.c > > @@ -507,10 +507,12 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc = *crtc, > > struct ltdc_device *ldev =3D crtc_to_ltdc(crtc); > > int rate =3D mode->clock * 1000; > > > > + clk_disable(ldev->pixel_clk); > > if (clk_set_rate(ldev->pixel_clk, rate) < 0) { > > DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate)= ; > > return false; > > } > > + clk_enable(ldev->pixel_clk); > > > > adjusted_mode->clock =3D clk_get_rate(ldev->pixel_clk) / 1000; > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel