Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4770377ybi; Tue, 28 May 2019 02:10:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIHryekt5hKDF6o6nTiGlfomfEQlEQkBBuxswaCz2Nib5gGWX/96M5yJ5xuyOyZzkpdEbS X-Received: by 2002:a63:5c1a:: with SMTP id q26mr21083046pgb.260.1559034607399; Tue, 28 May 2019 02:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559034607; cv=none; d=google.com; s=arc-20160816; b=uOxjSECoWOQrD5UQyw8zPYPQutKfHMsYRhZUyn7PFYsPELSNeqAtEwYi+0D9zmugns toFZ0XDkZasXDcxjsdUobYnWqDWxY88Glu3yYFVCXWUxy5OAU1wCbcJodH+HSO9TpiyF aV5RIAktI8C1K8lkJDsAwLjpnvEuk2Tph48GD0nfp/EsKp4JMs/l+vaY9R2TKvnDcJJx cxiMt4tbxMlldl+nIseX0DHevOTi3NowxVG0W2ofEIUbHWeDrnhaPZcnp/RwNlLC7YND w+NOeOPBxF6uTx3e2cR7NfZzmmkDlqyV5y3/5lvED5GKmTsnDK3LnFLENOzA1AszreD0 R6Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=01fUYB3VzPGfcTugqgqBx5jW8iq7wLyVUX3qXdYLYSk=; b=q4uQL3Ngr0JQVJK+/kekjyHzCg0Wm6x5da1+ltqtYV2lOp0ibkF6qTJ2YU6i/u8l3M VamTKoxyDPT1uLSkYFcrGh7j8/McRGfWcaSarDXTTQw7Tz/f+/8ssBq2Oku+j8Gt/t/3 /nnfk/VTbyZTwwT1WkFxajCnHZT7lM7ff2aunamC3ITjEB0Hg6hiWmRW33gRV0Ys/gye ilqIV6AH1j/yE5SzaHKfjeGiQCKRqfzwGFWjED3rh4ZXRRolf58UyzVmyrHmTiEHwio+ UcGeIWnjIz2vXUyppFRvCGYk2k8Fyyq8j7IrppgRJNyXiunW5mtidGGoV7ACum10JuOh sYmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="DIUw/kO/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q15si2699249pjp.95.2019.05.28.02.09.51; Tue, 28 May 2019 02:10:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="DIUw/kO/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbfE1JGZ (ORCPT + 99 others); Tue, 28 May 2019 05:06:25 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35997 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727036AbfE1JDe (ORCPT ); Tue, 28 May 2019 05:03:34 -0400 Received: by mail-ed1-f67.google.com with SMTP id a8so30639339edx.3 for ; Tue, 28 May 2019 02:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=01fUYB3VzPGfcTugqgqBx5jW8iq7wLyVUX3qXdYLYSk=; b=DIUw/kO/LXyngvpKwzC2ewKvPzp/6OUUrTW3jHZNYZjGOyfUOx9k0Ymf2PWGe0uTX1 aFGbqCs0JBCbXRctZ3Clc9hEOdMbgD2j3dVb6uM642xcQ+8j4uPyEreOpxw8GzNrxnV1 fOlYw4DwyEZcV634rmGq6J/k76ZdCQuxlqhWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=01fUYB3VzPGfcTugqgqBx5jW8iq7wLyVUX3qXdYLYSk=; b=D7U+DwqML9tFImDP3+cQ0kDR0sQaIhk+r7vxVzuMgjeLcdlBHB/qFnrFNn4RSOg0aX AsUKkIrnOQtPzvr5X0m7dhpWvmlzJ823KLsF+qS3zaaN7if0491pIvx1E/bjdMLYR9n4 m0RJfuLcRcaAgbw1ywLBdrN1UlqYndU0TIeJqp8BVnEb2LKS+6f4VvbLtTIwYAJ1/MKr vYiTKm3HAca6VlAIjhG6cRXfAvA5tc7n60RifZJj78D7iPkrtAh+M9FXs5EVqv9m8TSC LVqqy92udcbWzldH45uZQfTK/NyjwTkAVooQP9gK3JKGeoIOavJd1J2SIrjEZbqyRDU4 t6WQ== X-Gm-Message-State: APjAAAUfXqsOOuCXTWHtFj+csGvMZ/bzvRLa9YRlcUi7hYwAaikKHVGV HxWOrWlVvX7Whl0yqUJhplO4Tx/r8Hc= X-Received: by 2002:a50:8903:: with SMTP id e3mr126039162ede.11.1559034213606; Tue, 28 May 2019 02:03:33 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id x49sm4072656edm.25.2019.05.28.02.03.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 02:03:32 -0700 (PDT) From: Daniel Vetter To: LKML Cc: DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , Sam Ravnborg , Maarten Lankhorst , Mikulas Patocka , "David S. Miller" , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [PATCH 15/33] fbdev/atyfb: lock_fb_info can't fail Date: Tue, 28 May 2019 11:02:46 +0200 Message-Id: <20190528090304.9388-16-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190528090304.9388-1-daniel.vetter@ffwll.ch> References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's properly protected by reboot_lock. Signed-off-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by: Maarten Lankhorst Cc: Mikulas Patocka Cc: "David S. Miller" Cc: "Ville Syrjälä" Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter --- drivers/video/fbdev/aty/atyfb_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index b6fe103df145..eebb62d82a23 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -3916,8 +3916,7 @@ static int atyfb_reboot_notify(struct notifier_block *nb, if (!reboot_info) goto out; - if (!lock_fb_info(reboot_info)) - goto out; + lock_fb_info(reboot_info); par = reboot_info->par; -- 2.20.1