Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI
 is available
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Julien Grall <julien.grall@arm.com>,
        Simon Horman <horms@verge.net.au>,
        Magnus Damm <magnus.damm@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
References: <1558087093-22113-1-git-send-email-olekstysh@gmail.com>
 <CAMuHMdVC=aNQTZ0r+7qpiWEyEaoQ587pm1FxhWqR3pwHwv2ARg@mail.gmail.com>
From:   Oleksandr <olekstysh@gmail.com>
Message-ID: <6d3160d2-ce36-980a-1054-03bdece5bbfc@gmail.com>
Date:   Tue, 28 May 2019 13:10:42 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAMuHMdVC=aNQTZ0r+7qpiWEyEaoQ587pm1FxhWqR3pwHwv2ARg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 28.05.19 11:27, Geert Uytterhoeven wrote:
> Hi Oleksandr,

Hi Geert, all


> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you for review!


Just FYI:

Required support for Gen2 Stout board has been already added to Xen [1].

What needs to be done next is to add support for handling device-tree 
nodes with "interrupts-extended" property in Xen [2].
This is related to Gen3 as well.


[1] 
https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg44386.html

[2] 
https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg45951.html

>
> Two cosmetic comments below. I'll leave it to Simon to ignore them for
> applying ;-)
>
>> @@ -62,6 +63,21 @@ void __init rcar_gen2_timer_init(void)
>>   {
>>          void __iomem *base;
>>          u32 freq;
>> +       bool need_update = true;
> Some people like reverse Xmas tree declaration order...
>
>> +
>> +       /*
>> +        * If PSCI is available then most likely we are running on PSCI-enabled
>> +        * U-Boot which, we assume, has already taken care of resetting CNTVOFF
>> +        * and updating counter module before switching to non-secure mode
>> +        * and we don't need to.
>> +        */
>> +#if defined(CONFIG_ARM_PSCI_FW)
> #ifdef CONFIG_ARM_PSCI_FW ?
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
-- 
Regards,

Oleksandr Tyshchenko