Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190521234148.64060-1-drinkcat@chromium.org> <11be5350-23db-6216-3c2b-1d8b161cac9b@yandex-team.ru>
In-Reply-To: <11be5350-23db-6216-3c2b-1d8b161cac9b@yandex-team.ru>
From:   Nicolas Boichat <drinkcat@chromium.org>
Date:   Tue, 28 May 2019 18:28:20 +0800
Message-ID: <CANMq1KDUCJhEKPSnjoCB=PyrvU3zF77miPC8Kqy2ttporMst8A@mail.gmail.com>
Subject: Re: [PATCH] scripts/decode_stacktrace: Look for modules with
 .ko.debug extension
To:     Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Marc Zyngier <marc.zyngier@arm.com>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 28, 2019 at 4:38 PM Konstantin Khlebnikov
<khlebnikov@yandex-team.ru> wrote:
>
> On 22.05.2019 2:41, Nicolas Boichat wrote:
> > In Chromium OS kernel builds, we split the debug information as
> > .ko.debug files, and that's what decode_stacktrace.sh needs to use.
> >
> > Relax objfile matching rule to allow any .ko* file to be matched.
> >
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >   scripts/decode_stacktrace.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> > index bcdd45df3f5127a..c851c1eb16f9cf7 100755
> > --- a/scripts/decode_stacktrace.sh
> > +++ b/scripts/decode_stacktrace.sh
> > @@ -28,7 +28,7 @@ parse_symbol() {
> >               local objfile=${modcache[$module]}
> >       else
> >               [[ $modpath == "" ]] && return
> > -             local objfile=$(find "$modpath" -name $module.ko -print -quit)
> > +             local objfile=$(find "$modpath" -name $module.ko* -print -quit)
>
> Ok but should be quoted "$module.ko*" or escaped $module.ko\*

Thanks for noticing, will send a v2 right away.

> >               [[ $objfile == "" ]] && return
> >               modcache[$module]=$objfile
> >       fi
> >