Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCHv6 3/4] drm/omap: add framedone interrupt support
To:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        Sebastian Reichel <sre@kernel.org>,
        Tony Lindgren <tony@atomide.com>, Pavel Machek <pavel@ucw.cz>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     "H. Nikolaus Schaller" <hns@goldelico.com>,
        <dri-devel@lists.freedesktop.org>, <linux-omap@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel@collabora.com>
References: <20190523200756.25314-1-sebastian.reichel@collabora.com>
 <20190523200756.25314-4-sebastian.reichel@collabora.com>
From:   Tomi Valkeinen <tomi.valkeinen@ti.com>
Message-ID: <9eb23a5d-438e-7b25-e7cb-8b734a150e43@ti.com>
Date:   Tue, 28 May 2019 13:19:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190523200756.25314-4-sebastian.reichel@collabora.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sebastian,

On 23/05/2019 23:07, Sebastian Reichel wrote:

> @@ -302,6 +328,30 @@ void omap_crtc_vblank_irq(struct drm_crtc *crtc)
>   	DBG("%s: apply done", omap_crtc->name);
>   }
>   
> +void omap_crtc_framedone_irq(struct drm_crtc *crtc, uint32_t irqstatus)
> +{
> +	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
> +
> +	if (!omap_crtc->framedone_handler) {
> +		dev_warn(omap_crtc->base.dev->dev, "no framedone handler?");
> +		return;
> +	}

This triggers on normal displays.

FRAMEDONE is an interrupt we get when DISPC's output videoport is being 
turned off. It's raised after the last frame has been finished (i.e. the 
DISPC is truly done with that videoport).

We get it for both conventional displays (when the display is turned 
off) and for DSI command mode (when a single frame has been sent), as in 
both cases the videoport is disabled after the operation. For 
conventional displays, you can think FRAMEDONE as the last vsync.

We also have special handling for FRAMEDONE in omap_crtc_set_enabled(), 
which is used to get the drm driver to wait for FRAMEDONE when disabling 
the display. I wonder if this separate framedone handling might somehow 
conflict with that code. And/or should these be somehow combined.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki