Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030241AbVKPJAc (ORCPT ); Wed, 16 Nov 2005 04:00:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030248AbVKPJAc (ORCPT ); Wed, 16 Nov 2005 04:00:32 -0500 Received: from smtp.osdl.org ([65.172.181.4]:21203 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030241AbVKPJAb (ORCPT ); Wed, 16 Nov 2005 04:00:31 -0500 Date: Wed, 16 Nov 2005 00:59:58 -0800 From: Andrew Morton To: Cal Peake Cc: linux-kernel@vger.kernel.org, jcm@jonmasters.org, torvalds@osdl.org, viro@ftp.linux.org.uk, hch@lst.de Subject: Re: floppy regression from "[PATCH] fix floppy.c to store correct ..." Message-Id: <20051116005958.25adcd4a.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 32 Cal Peake wrote: > > Hi, > > Commit 88baf3e85af72f606363a85e9a60e9e61cc64a6c: > > "[PATCH] fix floppy.c to store correct ro/rw status in underlying gendisk" > > causes an annoying side-effect. Upon first write attempt to a floppy I get > this: > > $ dd if=bootdisk.img of=/dev/fd0 bs=1440k > dd: writing `/dev/fd0': Operation not permitted > 1+0 records in > 0+0 records out > > Any successive attempts succeed without problem. Confirmed that backing > out the patch fixes it. > hmm, yes, when floppy_open() does its test we haven't yet gone and determined the state of FD_DISK_WRITABLE. On later opens, we have done, so things work OK. We may be able to do the test at the end of floppy_open(), after check_disk_change() has called floppy_revalidate(). But for O_NDELAY opens we appear to be screwed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/