Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932594AbVKPJ6s (ORCPT ); Wed, 16 Nov 2005 04:58:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932595AbVKPJ6s (ORCPT ); Wed, 16 Nov 2005 04:58:48 -0500 Received: from ns2.suse.de ([195.135.220.15]:44459 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932594AbVKPJ6r (ORCPT ); Wed, 16 Nov 2005 04:58:47 -0500 Message-ID: <437B02C8.4080504@suse.de> Date: Wed, 16 Nov 2005 10:58:32 +0100 From: Gerd Knorr User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050715) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Roland Dreier Cc: Linus Torvalds , Dave Jones , Zachary Amsden , Pavel Machek , Andrew Morton , Linux Kernel Mailing List , "H. Peter Anvin" , Zwane Mwaikambo , Pratap Subrahmanyam , Christopher Li , "Eric W. Biederman" , Ingo Molnar Subject: Re: [PATCH 1/10] Cr4 is valid on some 486s References: <200511100032.jAA0WgUq027712@zach-dev.vmware.com> <20051111103605.GC27805@elf.ucw.cz> <4374F2D5.7010106@vmware.com> <4374FB89.6000304@vmware.com> <20051113074241.GA29796@redhat.com> <4378A7F3.9070704@suse.de> <4379ECC1.20005@suse.de> <437A0649.7010702@suse.de> <52r79h7v2f.fsf@cisco.com> In-Reply-To: <52r79h7v2f.fsf@cisco.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 24 Roland Dreier wrote: > > +#define alternative_smp(smpinstr, upinstr) asm(upinstr, ##input) > > this wouldn't build with CONFIG_SMP=n -- you forgot the input param here. Yep, and I've noticed meanwhile that it becomes quite messy if you try to do that with asm instructions which have both input and output parameters. One way around that would be to use named parameters in the inline assembler. Problem with that is that only gcc >= 3.1 understands those and at the moment the minimun requited compiler for the kernel still is gcc 2.95.3 according to Documentation/Changes ... Is it an option to raise the required gcc version to 3.x, given that even Debian/stable ships with gcc 3.3 these days? cheers, Gerd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/