Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 May 2019 11:29:56 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tomas Bortoli <tomasbortoli@gmail.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: Avoid memory leak in predicate_parse()
Message-ID: <20190528112956.4cf2dd9c@gandalf.local.home>
In-Reply-To: <1a9137e1-bcc3-787f-267c-8b76dea41fbb@gmail.com>
References: <20190528134659.4041-1-tomasbortoli@gmail.com>
        <20190528104400.388e4c3f@gandalf.local.home>
        <1a9137e1-bcc3-787f-267c-8b76dea41fbb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 May 2019 17:18:59 +0200
Tomas Bortoli <tomasbortoli@gmail.com> wrote:

> >> +	memset(prog_stack, 0, nr_preds * sizeof(*prog_stack));
> >> +  
> > 
> > Can you instead just switch the allocation of prog_stack to use
> > kcalloc()?  
> 
> kmalloc_array() is safe against arithmetic overflow of the arguments.
> Using kcalloc() directly we wouldn't check for that. Not really ideal in
> my opinion. And there's no kcalloc_array() apparently!

But doesn't kcalloc() simply call kmalloc_array() with the GFP_ZERO
flag?

-- Steve