Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190524003038.GA69487@ip-172-31-44-144.us-west-2.compute.internal>
In-Reply-To: <20190524003038.GA69487@ip-172-31-44-144.us-west-2.compute.internal>
From:   Song Liu <liu.song.a23@gmail.com>
Date:   Tue, 28 May 2019 09:45:14 -0700
Message-ID: <CAPhsuW7H=w_UMyu5Q5p5+MGogkQ7+7X7sS=vJTiR=+JJy0KuTg@mail.gmail.com>
Subject: Re: [PATCH] selftests: bpf: fix compiler warning
To:     Alakesh Haloi <alakesh.haloi@gmail.com>
Cc:     Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        Stanislav Fomichev <sdf@google.com>,
        linux-kselftest@vger.kernel.org,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 23, 2019 at 5:31 PM Alakesh Haloi <alakesh.haloi@gmail.com> wro=
te:
>
> Add missing header file following compiler warning
>
> prog_tests/flow_dissector.c: In function =E2=80=98tx_tap=E2=80=99:
> prog_tests/flow_dissector.c:175:9: warning: implicit declaration of funct=
ion =E2=80=98writev=E2=80=99; did you mean =E2=80=98write=E2=80=99? [-Wimpl=
icit-function-declaration]
>   return writev(fd, iov, ARRAY_SIZE(iov));
>          ^~~~~~
>          write
>
> Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com>

The patch looks good. Please add a "Fixes" tag, so the fix
can be back ported properly.

Also, please specify which tree the patch should be applied
with [PATCH bpf] or [PATCH bpf-next].

Thanks,
Song


> ---
>  tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/to=
ols/testing/selftests/bpf/prog_tests/flow_dissector.c
> index fbd1d88a6095..c938283ac232 100644
> --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c
> @@ -3,6 +3,7 @@
>  #include <error.h>
>  #include <linux/if.h>
>  #include <linux/if_tun.h>
> +#include <sys/uio.h>
>
>  #define CHECK_FLOW_KEYS(desc, got, expected)                           \
>         CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) !=3D 0,          =
 \
> --
> 2.17.1
>