Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5252465ybi; Tue, 28 May 2019 09:53:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTRDQo7/K3JEXdJKj7IFYa7mkLmMQVBfjyeYQlXTCHXbk75T/H6zGNSxP+VrhOQPF4l+5k X-Received: by 2002:a65:430a:: with SMTP id j10mr87515789pgq.133.1559062435067; Tue, 28 May 2019 09:53:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559062435; cv=none; d=google.com; s=arc-20160816; b=ZE1ZkxoKll3XrzzZ9Zd+R2ypdIYP2r6fFoXbf8H0dPY6ZU6t+OtJQ3GKjRoyith5Xq G1b3VqA/GIuM750j782k7nDbs3LsumjcYAxxlwbYFR7dMSL0fl8plv69dTSMR08YIPg/ VW4b2IC3YMsgeM4jm6jJjuqsJ+hCiZZfTEz2ETuAFi1aTZbG0zsIAbpbDnlQBLvOLTdZ nvV2w04oK+bbjPC3M3elwvaONzPI403bmZJ0AavjyxzLvvkhCO0F7iTq3pouWe76Q6xn avE2PFqm1PPR9BfhNxvKKDNcdX7jpZY7eSD16CVDrwUFeAPyoBDSlrA3ywIMuTqtFPmC rZ7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CSrPAdXVG2PPSgKELxFOFFehvoXAPD5g1uoAw4jiONo=; b=vTCjI53yVkB13bBWL1zv1aRCJUo22SavZchoqbRxzQ6+SRfDryQga4GYj2texRevab GJWCG16l4AtbcA7nXmrrEf9utSsb6g0ggVLse2Ec5Iq4rOyzwmND0Ymv7KxON5aOPY2p 6YaellVqBHBSip3XmA2FZeIHf1bN2kkwvP8Gd7om0j2r5/oxns0JQCaG4Km3JrhYuiEN c80GFflkL2zn1Mw9dlxiBa/2x7EFCk9GyBOxtCEWMWiE3TZHbnKtcOx12GvvRFBw2U7S uLe2WMnPJaWApp2fLf1gZnbzj+MJ5YpjaLOVVgTKu77xTQkfwTYt4x6yHpNhzrZM9XrG FQuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13si22172088pgs.90.2019.05.28.09.53.39; Tue, 28 May 2019 09:53:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfE1Quy (ORCPT + 99 others); Tue, 28 May 2019 12:50:54 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:32984 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbfE1Quy (ORCPT ); Tue, 28 May 2019 12:50:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB43CA78; Tue, 28 May 2019 09:50:53 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D794C3F59C; Tue, 28 May 2019 09:50:50 -0700 (PDT) Date: Tue, 28 May 2019 17:50:48 +0100 From: Mark Rutland To: Marco Elver Cc: peterz@infradead.org, aryabinin@virtuozzo.com, dvyukov@google.com, glider@google.com, andreyknvl@google.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, jpoimboe@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH 1/3] lib/test_kasan: Add bitops tests Message-ID: <20190528165048.GD28492@lakrids.cambridge.arm.com> References: <20190528163258.260144-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190528163258.260144-1-elver@google.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, May 28, 2019 at 06:32:56PM +0200, Marco Elver wrote: > +static noinline void __init kasan_bitops(void) > +{ > + long bits = 0; > + const long bit = sizeof(bits) * 8; You can use BITS_PER_LONG here. Thanks, Mark.