Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5274634ybi; Tue, 28 May 2019 10:14:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMbYEpsmv3NbJqxqufRDFRh1IHFVKkD+MX5TX3V9/Pr99ATB62PJRXFRMSVkoBVzav5tHv X-Received: by 2002:a17:90a:37c2:: with SMTP id v60mr140380pjb.24.1559063667324; Tue, 28 May 2019 10:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559063667; cv=none; d=google.com; s=arc-20160816; b=L1o+AhbPpCZEgzX74n2w7R9cnc8tG6709vlaY2DLIqqfGhr4IxtQZ2qC8nSrtUAsRo 6H2ffxQbJIu1keyjvjZrD4SYwfWl3yhQd16wHMgOEaSzKDs5QLylO04x/teN+tIyqiTF edx5SgXE7WQOfZOTCbS6hZ1Tm/kOT6ZIkK/myY7qJ62hNB79HR0SFcGEBnCytLswWtaw 0fjBZvO2SBjfRRg+ZUSVk9ddZOps0Cx/KwiBM65EQlWS1ICGEA4cIvI+4SodU3DasYjJ We4Muf28GwIoCFCmRZTR0CuFbt2iAn06NOYoINOx44IGdUmUvtTR20L49oHtDTyCSJ0C sTTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7II5+XRnVobtVPgQVRQrDR8x4e5To08TyrztMHGvqag=; b=VO9CXNIT5jySbNY8CfjyUKF9Yym9zGxmJJg70H77mxQtR9o7lIxmqDmj+iPfnF/H6V OzhX0ZpGupWYN3c3MM19vPF+DQ60xghDNJ+Iwq/9yVV5PCT2njGtMbcaduX3PsJkuhhi tKn/MiVLgURXpq9do1oE2xe8QVLzNOT0IaTEG84AgYVCc1k0pRJLcYoDmKWB33fAT9uH wEEJ4w4jCcn5fzR5BsWyKHrgllJsFHWRdhdl4TxLp/CIEcorv/Ry/sEz6QXCVJvfc8eR DuS94nEzAvYTHsJP/jfsQyxU9BgN0J19ebTf9bbgeAnAMbYWjUVdPoBvLkC9M7DolxOH 6/KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eaq0BTRP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r69si22342703pgr.120.2019.05.28.10.14.11; Tue, 28 May 2019 10:14:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eaq0BTRP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726927AbfE1RM7 (ORCPT + 99 others); Tue, 28 May 2019 13:12:59 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40130 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfE1RM7 (ORCPT ); Tue, 28 May 2019 13:12:59 -0400 Received: by mail-lf1-f68.google.com with SMTP id h13so15206400lfc.7; Tue, 28 May 2019 10:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7II5+XRnVobtVPgQVRQrDR8x4e5To08TyrztMHGvqag=; b=eaq0BTRPkhNafZhWSSYSrscltuZlK8p6kHWOeCVXycDQv7t3RspcGhqc4CbVFRfJ0/ o7HJXatIFeoKZxyCMT287FoSfvrUs0U0xqqF+ZyaTxsF6AXOvHhx+mEnvBMiZVkkC7ec QCS0S+APb1j6fW2ryNi4o7g80ajjVeRBHQNbzfaBo7pN07pH1YZkz60t0gSOOA3Sa77n IUDDmczlKJ9hmuAndnQn4+Y/SUZKWO+OMmA80g+gjOLOd+UpCkLuevIe+dS8TuJtPJey 2PC562PZ6yYaNgc3BidpuZdLxw+bNgr4tYYphKwEZ3XqIzT7w38tkPatdRI9FkWb/PTS N+nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7II5+XRnVobtVPgQVRQrDR8x4e5To08TyrztMHGvqag=; b=DUO5En1dTvbSXbQmc1GJnFFO6BTzt4kM8cklYJFWB48yixiorxlkVoiTq/CxBHIffZ iXHVIvJO+E1H3MlLjs+L7VjJ6bmW9oXtjSuz+E1M80xJUtSiXHOVRBxHWDMMs+vYxdr3 xgwBrmnqGu/zrcbdfPuBkBn0kMUBrw3XWHGcaUoTh0wehFtWK2F/YtcWJRKTGTcxWsX7 r0foGPhd8Knt/9VDehH3QdBJALvz7SfQKfZ30t0k8j6p7VEpTpGu/BO1vwA2kowJVvx+ 6IGIadI3kyMYpxG1EcOxZYvXPUNygFjtHuIpGsSebpqwxVYLDjGgIyjCGU7ptKvSbhza TB/Q== X-Gm-Message-State: APjAAAV93OVsPOgfGkrb1W0J7jh4irOp4k8Y9FXBiOP1B7gDtgZUVm2l ftnfML7vEQ2TwlaUI2Om6fk= X-Received: by 2002:ac2:4908:: with SMTP id n8mr3692243lfi.10.1559063577452; Tue, 28 May 2019 10:12:57 -0700 (PDT) Received: from esperanza ([176.120.239.149]) by smtp.gmail.com with ESMTPSA id x14sm2989317lfe.83.2019.05.28.10.12.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 10:12:56 -0700 (PDT) Date: Tue, 28 May 2019 20:12:54 +0300 From: Vladimir Davydov To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Johannes Weiner , Michal Hocko , Rik van Riel , Shakeel Butt , Christoph Lameter , cgroups@vger.kernel.org, Waiman Long Subject: Re: [PATCH v5 4/7] mm: unify SLAB and SLUB page accounting Message-ID: <20190528171254.ymnytie2uc4hwd4v@esperanza> References: <20190521200735.2603003-1-guro@fb.com> <20190521200735.2603003-5-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521200735.2603003-5-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 01:07:32PM -0700, Roman Gushchin wrote: > Currently the page accounting code is duplicated in SLAB and SLUB > internals. Let's move it into new (un)charge_slab_page helpers > in the slab_common.c file. These helpers will be responsible > for statistics (global and memcg-aware) and memcg charging. > So they are replacing direct memcg_(un)charge_slab() calls. > > Signed-off-by: Roman Gushchin > Reviewed-by: Shakeel Butt > Acked-by: Christoph Lameter Makes sense even without the rest of the series, Acked-by: Vladimir Davydov