Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5308302ybi; Tue, 28 May 2019 10:50:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFZAde0jv8okpxPsdGVtgzm82tw380QFK/7urXwvd1xGRerrcC128nEn0U6Zq89iF/l8BV X-Received: by 2002:a65:51cb:: with SMTP id i11mr42748298pgq.390.1559065849614; Tue, 28 May 2019 10:50:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559065849; cv=none; d=google.com; s=arc-20160816; b=x9kPj8Og7HKIluBWGxOxHdm7uPjoQ36DbJg1D95/9M09orpP/zbHyNJdGPRFKyF0Qi ljfzs02CJ89C51EN450TnhGWkHoYsXZ5Hil13qaj893kDzQGg7XKrwyKIlA3enJZELJy x0kDwUf/cBM+CwvZ6Kq4VmDIwHKwd4dqSpK5+bccGq+l7lrnHzTTxmfa9L5fNpmL+gmr DND5Puzy6hg1QTX+nXDwVqIoOxC+govBt/lnPK4at/4in3p395eYc6gsOEJ4vXF0Ubmx +npx6jbR8M1dwEDtpjYNnqkNvJXMpqvX9r1NyP0bnBiQID+8GkdZ7wCoDuoBfHeRIZ9z Gp4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from; bh=ZrB5zkhzjTBqhHnVyfvbRJbzizX+FL5Fck+uuONjaPA=; b=zK3NhPX4CoKdfcU+UwhX8AOLMLh+k1EQ0g8AgLQRmRLAH7h/MWzv5ju/4dWBeEPRKy rXnWlDsGyT5+6EXJHM0ZNY0YZEQKPMx+hT68twxZnCyeQotaWw/w4doBvKoHMRJ9UV+S /VzTTXPBX+FS/CAUyJhCEFOuqr2HwlDU186K4FX3xFLvEL4J8WGG2ZyU4GI9bJHpFYHQ WkMgEPYjvIZzdxLMcTW/KfKgLNX9J2byw4F4GnwsAvk9KRSJNaJMGkUrZst8SFls2AiD c/WNI1vOVF01FBRPLwdePFddbO6DihgGZDlMykgqJw5pIFNPV/6MqyB/OlBxs7Wy/rP4 ARZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si23150030pgs.290.2019.05.28.10.50.33; Tue, 28 May 2019 10:50:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727565AbfE1Rrz (ORCPT + 99 others); Tue, 28 May 2019 13:47:55 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46278 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfE1Rrx (ORCPT ); Tue, 28 May 2019 13:47:53 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 7195E263975 From: Gabriel Krisman Bertazi To: "Gustavo A. R. Silva" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] unicode: replace strncpy() by strscpy() Organization: Collabora References: <20190527174733.GA29547@embeddedor> Date: Tue, 28 May 2019 13:47:49 -0400 In-Reply-To: <20190527174733.GA29547@embeddedor> (Gustavo A. R. Silva's message of "Mon, 27 May 2019 12:47:33 -0500") Message-ID: <8536kympx6.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Gustavo A. R. Silva" writes: > The strncpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warning: > > "Calling strncpy with a maximum size argument of 12 bytes on destination > array version_string of size 12 bytes might leave the destination string > unterminated." > > Notice that, unlike strncpy(), strscpy() always null-terminates the > destination string. > Thanks, I'll get this queued up. -- Gabriel Krisman Bertazi