Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5341391ybi; Tue, 28 May 2019 11:21:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCgjsbEE8F2UezZWaS9cq26kVVvv5rQDAbqJyM3utINTEQ3vG94earbu6OV1t+me5ct48r X-Received: by 2002:a17:902:205:: with SMTP id 5mr20800469plc.165.1559067697028; Tue, 28 May 2019 11:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559067697; cv=none; d=google.com; s=arc-20160816; b=YVVd39B//3HCm7/fEy6evtlZeaWoFkNm0ongebdQojpTWC5LiKfN1CnBgn+Wb3pUE4 LwDR2qFv9l+PG56Iy5N3wBUOC/DOcC/LQRyWO+DvxzNRgBF0wFjaAke8DptK+JZCYsMN ZVTQVuSjlS9FV21uJrgSQ65Jd5Lj+8m9ZgQQmhJU5EyqK3D4KPbz6WBevOQ6SiZVxlR4 X3aV9dPEcb6IKqpvzlE6PtCokZ8p61YKRwg4ilZCisQXJCYL2mVpTqi5djLEHkzajh0j sg7M65QVSsPnr1sc6ERcsEfy9qZ92PiBH2nih7knwIlqC9mwynMZ3FKA/NILzJEmazN5 rsiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=FHBxN25oKeInyBYHIzdz2Mbx2pen9sGOw8A9sYUQEPA=; b=H1mFSDWbO2agQAQSN1Dd0nq7KZYem9DXcSgaaMpwGz+S8KiNw/h2Y9/5zSaqMy3vKE pVW17K6XoGT0GOqWDCZYwp/I2XAaYN/f6+zOA0FGV2B0FoE6EIKcQD6v8q6VwjRzZLd8 22+Nef6qRJeJeojARLmyAmrkOZv5GiIKR5k5DBFzN9NROwUeYnZJxnRrqt0qxtkwIRlh r9VjXWN/oPf+i9ESs47Xl5J5DEMP9PBhH9y6hEd7ADJAoJ2OjdEl4ZQxbDSjEFPb0fAG UXzN0B+4wxrnTnLWM05GY7hk8dJfjvliZ3uAvw4X7GBQWZvSTiU2M39WHfydIfjpMdVQ vDdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=wyn34Lvv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4si15500949pgc.213.2019.05.28.11.21.20; Tue, 28 May 2019 11:21:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=wyn34Lvv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbfE1STT (ORCPT + 99 others); Tue, 28 May 2019 14:19:19 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:48044 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbfE1STS (ORCPT ); Tue, 28 May 2019 14:19:18 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x4SIJDN0049819; Tue, 28 May 2019 13:19:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1559067553; bh=FHBxN25oKeInyBYHIzdz2Mbx2pen9sGOw8A9sYUQEPA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=wyn34Lvv7tRksgPniyeCYM+lRAS6+HPlciStbaJeE2fr7kY1DAYG8FB8csBn/+8Y5 QEHRg9bhze1xLHslEfD38Nmp/ZFc7jqFPlW1ICByn7SUJUzncmFos3YhZNp13Hoppk QuwjX1JyFQB+hsfeUVPClUkwcFr7VcUaxW4bZ69k= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x4SIJDus038031 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 May 2019 13:19:13 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 28 May 2019 13:19:12 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 28 May 2019 13:19:12 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x4SIJCbT074115; Tue, 28 May 2019 13:19:12 -0500 Subject: Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition To: Jacek Anaszewski , , CC: , , References: <20190523190820.29375-1-dmurphy@ti.com> <20190523190820.29375-2-dmurphy@ti.com> <185abdd6-100c-0a71-2da9-8f556d8ea701@ti.com> <333167d0-4615-2fbe-e933-cbca623998ef@gmail.com> From: Dan Murphy Message-ID: Date: Tue, 28 May 2019 13:19:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <333167d0-4615-2fbe-e933-cbca623998ef@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacek On 5/28/19 12:44 PM, Jacek Anaszewski wrote: > Dan, > > On 5/28/19 7:32 PM, Dan Murphy wrote: >> Jacek >> >> On 5/27/19 3:00 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> Thank you for the update. >>> >>> One thing is missing here - we need to document how legacy brightness >>> levels map to the sub-LED color levels, i.e. what you do in >>> multicolor_set_brightness(). >> >> >> Ok so i will need to document the algorithm that is used to determine >> the color LED brightness. > > Right, and please send just an update of that single patch. > So you are asking for v4 with only this patch updated. Dan