Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965257AbVKPM4Q (ORCPT ); Wed, 16 Nov 2005 07:56:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965256AbVKPM4Q (ORCPT ); Wed, 16 Nov 2005 07:56:16 -0500 Received: from mail.dvmed.net ([216.237.124.58]:46771 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S965253AbVKPM4O (ORCPT ); Wed, 16 Nov 2005 07:56:14 -0500 Message-ID: <437B2C61.7080605@pobox.com> Date: Wed, 16 Nov 2005 07:56:01 -0500 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jens Axboe CC: Mike Christie , Tejun Heo , linux-ide@vger.kernel.org, lkml , SCSI Mailing List Subject: Re: [PATCH] libata error handling fixes (ATAPI) References: <20051114195717.GA24373@havoc.gtf.org> <20051115074148.GA17459@htj.dyndns.org> <4379AA5B.1060900@pobox.com> <4379B28E.9070708@gmail.com> <4379C062.3010302@pobox.com> <20051115120016.GD7787@suse.de> <437A2814.1060308@cs.wisc.edu> <20051115184131.GJ7787@suse.de> <20051116124035.GX7787@suse.de> In-Reply-To: <20051116124035.GX7787@suse.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 793 Lines: 21 Jens Axboe wrote: > I updated that patch, and converted IDE and SCSI to use it. See the > results here: > > http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq > > The main change from the version posted last october is killing the > 'slightly' overdesigned completion queue hashing. Nifty, I like. Comments: * use of spin_lock_irq() in all completion paths now makes me nervous. * certainly it's what SCSI does now, but is a softirq really necessary? Using a tasklet would kill all that per-cpu code, and notifier. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/