Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 28 May 2019 11:50:59 -0700
From:   Omar Sandoval <osandov@osandov.com>
To:     Peng Wang <wangpeng15@xiaomi.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Peng Wang <rocking@whu.edu.cn>
Subject: Re: [PATCH] block: use KMEM_CACHE macro
Message-ID: <20190528185059.GB25022@vader>
References: <20190527114835.2071-1-wangpeng15@xiaomi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190527114835.2071-1-wangpeng15@xiaomi.com>
User-Agent: Mutt/1.12.0 (2019-05-25)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 27, 2019 at 07:48:35PM +0800, Peng Wang wrote:
> From: Peng Wang <rocking@whu.edu.cn>
> 
> Use the preferred KMEM_CACHE helper for brevity.

Reviewed-by: Omar Sandoval <osandov@fb.com>

> Signed-off-by: Peng Wang <rocking@whu.edu.cn>
> ---
>  block/blk-core.c | 3 +--
>  block/blk-ioc.c  | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 1bf83a0df0f6..841bf0b12755 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1789,8 +1789,7 @@ int __init blk_dev_init(void)
>  	if (!kblockd_workqueue)
>  		panic("Failed to create kblockd\n");
>  
> -	blk_requestq_cachep = kmem_cache_create("request_queue",
> -			sizeof(struct request_queue), 0, SLAB_PANIC, NULL);
> +	blk_requestq_cachep = KMEM_CACHE(request_queue, SLAB_PANIC);
>  
>  #ifdef CONFIG_DEBUG_FS
>  	blk_debugfs_root = debugfs_create_dir("block", NULL);
> diff --git a/block/blk-ioc.c b/block/blk-ioc.c
> index 5ed59ac6ae58..58c79aeca955 100644
> --- a/block/blk-ioc.c
> +++ b/block/blk-ioc.c
> @@ -408,8 +408,7 @@ struct io_cq *ioc_create_icq(struct io_context *ioc, struct request_queue *q,
>  
>  static int __init blk_ioc_init(void)
>  {
> -	iocontext_cachep = kmem_cache_create("blkdev_ioc",
> -			sizeof(struct io_context), 0, SLAB_PANIC, NULL);
> +	iocontext_cachep = KMEM_CACHE(io_context, SLAB_PANIC);

This will change the name of the slab in slabinfo, but I can't imagine
that matters.

>  	return 0;
>  }
>  subsys_initcall(blk_ioc_init);
> -- 
> 2.19.1
>