Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5541700ybi; Tue, 28 May 2019 15:01:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqy4d4HO5m5DQ94lcdwX5M5DFcHZdme+oRVAB7YGhQGzd8dHJMBGO1iQvjwdpN01nlLyoDd3 X-Received: by 2002:a17:90a:2ec5:: with SMTP id h5mr8331013pjs.93.1559080915312; Tue, 28 May 2019 15:01:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559080915; cv=none; d=google.com; s=arc-20160816; b=cJu2CuXB6jF4Cz8o/U51NYGu0w88k73SzjkcBFICtvWbll5DSBq/tWSe344b1lngTG 3CgCVeSe1dlMX9pP5UZxblGRkSHSWLwEJq1uKfeC05jG5pl+uiiXGJL534rQfHwn++sL iGgc49XrFTjJbRj6u0KMlWpRA4CVDTpdkeszyUe2/MJlAu0YM53uv83O+apD0gCnXVVD oZwNFGV7iT7B6SKZLHg0T+t7weXHUSa+7mVxTVEd7f7oLmYBgEV+8d8pMBl0PHnXw2/i E4nCgAIIvRVO3m7HSazjrBjGwVUXuBe9BwGtRdQemkpcs1yc4TMT2NcouwNSsP2nSO/Z ytIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Zz3efGRJMkCi9u1FMXnDOgSGtU0NK8c6CTTxYaLRlUk=; b=v+3Zthh8TslEFwIwVbpJJlJL5rVjnzQuEE2jWHqV3zajjLnIvcegXgxanL4h8xQvSy mcQKxwWfJ+p9aQYfz3/hmpB2Z1AFXZZ1MsucNlwzwR5djLpFcQ3Mb64eLJeUuyoL5BAq ie0n+tZWlECnyRhWMZirlpfW5wCHLZnVK7N0zJvb4pqCbdEFmyRga2ndSA8jsHZK0/Zb Gi4vLKQCm/ewjwoX7CQ8uCi3EGPm3wgX9qSEM4ystZrCCamDTnhMOCSOOrTA0TrztE9K xeYTCyVsonqwXpcDs80QECe8F15gP9W/+3cpv1rcqNO9wQwmkuvEH5vp8JQToRbYyaNf L/Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=UZzU4SeJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16si24606459pfr.94.2019.05.28.15.01.38; Tue, 28 May 2019 15:01:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=UZzU4SeJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbfE1WAc (ORCPT + 99 others); Tue, 28 May 2019 18:00:32 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:33973 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfE1WAc (ORCPT ); Tue, 28 May 2019 18:00:32 -0400 Received: by mail-pg1-f193.google.com with SMTP id h2so27951pgg.1 for ; Tue, 28 May 2019 15:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Zz3efGRJMkCi9u1FMXnDOgSGtU0NK8c6CTTxYaLRlUk=; b=UZzU4SeJuNsj1RuhrcyrwW4MS5X4kGC8Ge0T2obb1h/h/CTewhMxNkcfTqUtxV7Ybt l9JJno+dbcn1nkV0bH46Xhs3idLMJ4T/k55B/bpWBy9ryQnadZtrxLIcchZWxAkYBAbu fbhRFIDfo0/NnrAyNaE2ecYXcWho1QdaI0s/85/A+X7r9AK+tHFK+6aNWEpQy9HQs8Bb Li6LBCRaI75me6R17Qp1LTHnXDTPmx2UWK0vuWad9yeDuO3j4ni9wGrrdVO0l8uqGxHW 8Dsgz6ec6+oz4dmuhnZIKpxAgp6jx6+atPwCgm0WJQwwyg81bncpkILNj4fcw8WBEp02 G2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Zz3efGRJMkCi9u1FMXnDOgSGtU0NK8c6CTTxYaLRlUk=; b=OQrJ+BDP1HOjW30+d3he1m46mwM+Dzj/kuDly4hL/+ozR6WBwsc2ukqiyXJgiMAbCF u1tGDvSfjlqzETNZ7TDY1mjsoc+7z670/8EvNY4Yzxo6pTXnNzbzrWR4C5ccKiilBHN0 AEn5x/Nrlme5QEe2UbEyvWE6IywrPXF3Yz1uxNZM8q4q6ZwNMV2o3f0diMRGzWtFgBk6 2GLD8Ph+5AoAr8tgrYd1GLe9jAafWBcYMnk/n/ZCWubKfpmElUUOhk/52biqG3ERJ8Vs kZixPoBtih6SYWgcHK4rpwFLW1Im/DMG48ywf62bYWkrZQrWGQVtKm1/e1YbImuTLP90 QMKQ== X-Gm-Message-State: APjAAAVygti0oHq1fYZTqR7qh+RpJk7tjW++94oxhmvRQ/h1AVRXHJfr F7/wVrswNOhRYxQSwf4pHSkJGQ== X-Received: by 2002:aa7:8c1a:: with SMTP id c26mr146120273pfd.25.1559080831650; Tue, 28 May 2019 15:00:31 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::1:77ab]) by smtp.gmail.com with ESMTPSA id i3sm8919865pfa.175.2019.05.28.15.00.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 15:00:30 -0700 (PDT) Date: Tue, 28 May 2019 18:00:28 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Michal Hocko , Rik van Riel , Shakeel Butt , Christoph Lameter , Vladimir Davydov , cgroups@vger.kernel.org, Waiman Long Subject: Re: [PATCH v5 4/7] mm: unify SLAB and SLUB page accounting Message-ID: <20190528220028.GB26614@cmpxchg.org> References: <20190521200735.2603003-1-guro@fb.com> <20190521200735.2603003-5-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521200735.2603003-5-guro@fb.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 01:07:32PM -0700, Roman Gushchin wrote: > Currently the page accounting code is duplicated in SLAB and SLUB > internals. Let's move it into new (un)charge_slab_page helpers > in the slab_common.c file. These helpers will be responsible > for statistics (global and memcg-aware) and memcg charging. > So they are replacing direct memcg_(un)charge_slab() calls. > > Signed-off-by: Roman Gushchin > Reviewed-by: Shakeel Butt > Acked-by: Christoph Lameter Acked-by: Johannes Weiner