Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5560700ybi; Tue, 28 May 2019 15:20:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcRGJ8w3VDdV76CRhmhgPYmQOvBeDEdc2aYrvA32R9qHL2UiLCMuRT+mkAn9kldgWyx422 X-Received: by 2002:a65:44c8:: with SMTP id g8mr135997274pgs.443.1559082055528; Tue, 28 May 2019 15:20:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559082055; cv=none; d=google.com; s=arc-20160816; b=HZu6vGsIAG6AE8evfsYEsagPHR5v9a5OL7/t7M01MRoEQ+kT9P5dh8jJvFruwla9k9 JLnSXJX5bhLZWU6cWf2z6D8r1wewvMHdPItB1TE8haXh/1vmjPwW+XAIzgrOb+Ws6KZI uMGWLF3teLOpyrdvnxd5kb34vpShCFX1W2la5KTexwbLrZqNyKDVRsm9EM01CSQo4nlL yC4dWIpDUsCN8hZSBJILEhoivLFoF2EoGWioKgwZPI3AomrQSETznCdceuqrRZJPRD6b /cWMTcPENmXSlWj1sqsn4zWtmPkIBaWNATvwaRI9ku83JDG9vc2auvMeSXSpYROEpSkj vGyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=obp2ubRW+FQX4pRpXd+w8QI/80Ao6XWO4ssAjppQO3o=; b=XjODILnqLf8hBZhOkJcVBamcZHgkCpfDbnqUWbOSUA/LCH+2I/hp5YPBUEcTuB0fE3 2yAuYKiyALIdqonpQyZYtxxyPAzX3doVQET2deOiBiv58KABY3ZULH3ZpwW12sWo+jMU lqytEoFMEKl5mi2vzZNOlugLE79HM4Aj6U3IBUOyHWKml4l42t03M9mAFcPkd10tPMIS SmCoWDxBWbHHEdMF50l1eC03pFC01r+c0yKXts8YtwiErYVaceqWShQs/ycRWvsp6PLo dAq68h8zAVOAfBkuIXM8ojtmtcT0Q+FrmbBo+PXAFOcPIc0Gn3xrHok08WE67rdMPytv nNsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w27si25018923pgl.277.2019.05.28.15.20.39; Tue, 28 May 2019 15:20:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728091AbfE1WFZ (ORCPT + 99 others); Tue, 28 May 2019 18:05:25 -0400 Received: from ja.ssi.bg ([178.16.129.10]:55672 "EHLO ja.ssi.bg" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726576AbfE1WFZ (ORCPT ); Tue, 28 May 2019 18:05:25 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.15.2/8.15.2) with ESMTP id x4SM4E6G010937; Wed, 29 May 2019 01:04:14 +0300 Date: Wed, 29 May 2019 01:04:14 +0300 (EEST) From: Julian Anastasov To: Jacky Hu cc: jacky.hu@walmart.com, jason.niesz@walmart.com, Wensong Zhang , Simon Horman , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH v2] ipvs: add checksum support for gue encapsulation In-Reply-To: <20190526064819.16420-1-hengqing.hu@gmail.com> Message-ID: References: <20190526064819.16420-1-hengqing.hu@gmail.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sun, 26 May 2019, Jacky Hu wrote: > +/* Tunnel encapsulation flags */ > +#define IP_VS_TUNNEL_ENCAP_FLAG_NOCSUM (0) > +#define IP_VS_TUNNEL_ENCAP_FLAG_CSUM (1<<0) > +#define IP_VS_TUNNEL_ENCAP_FLAG_REMCSUM (1<<1) scripts/checkpatch.pl --strict file.patch reports for some issues you should resolve for v3. Otherwise, the patch looks good to me. Regards -- Julian Anastasov