Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5664497ybi; Tue, 28 May 2019 17:26:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqxiSznHSenfrOO+hqE9wuhl/ox9Tz17Mn7y2Pkv2yt0NyVGH2u1M67yCuSX800del4EQEh3 X-Received: by 2002:a17:902:1121:: with SMTP id d30mr42825794pla.153.1559089585946; Tue, 28 May 2019 17:26:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559089585; cv=none; d=google.com; s=arc-20160816; b=FsNFU8dK07ru+kFCl0KyZXjeVnHlSxe+h/2I0O/TuGXc/MC/N4CV2nPIGgLbE0eVR8 9tJvZvvsAFJuJXgcTbDcBdJYmHIVWuOZa4V8XnVqgj0eIHVyEl9bO0z0sizvbDiaMo4Q a0ZfScoNc9CKfq2DCNGhpVIsT1tUUy9yrgZMaBwW7klLrdR7DauVa2xAcCMNLmBzlGnJ qVx0AeUxSKuQepiRv4M1qW6WZxmInOl0t84wksOqoyQ3Yh7Ob/YaBlVcTxDzmqBpqoIW 7ZZ08ZUjoMzNb6aEs1wpDaUBNfJLTEpUL9Ww01hUn/FH5oawmCaQIO3xjpjvF2fx1yAT 91Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=eGnTXueNnC5ih6h78AMZBLIRmZ2Ezz3DuBHwa6kS8nw=; b=kE4jh5FP4sqGjNFVXvM8gGMSnbSkOnP9j9idpfAxQ45Eq9wBKA4/lqhAlL/UFMk4Jc JSrefbstocNv4Z9mtp/phYvg1+2I7g3oBZ/veAynHoj2TO/oCsZbbcWTsT4d2HJoU3TE cxVjdxBTGuUcsvDX34WX+QGUpsKVKgLaKvk5gJKD1IwTcgmReVMmxBMeSFnEr+GzSYIQ V8n6ncUZya5p3zCAuYT1tugvzARySCXCbaUzqGiU7fsu4Eyh/3P6v5bWFuRtdvpI6rDz A3forWDbFMBLtRlkRedad3EJjNcfDjiANRfocv6tqqShXizgfZ0l/HHLYWvbQNptkG6A iY3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si22591769plr.378.2019.05.28.17.26.10; Tue, 28 May 2019 17:26:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727538AbfE2AZA (ORCPT + 99 others); Tue, 28 May 2019 20:25:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54454 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfE2AZA (ORCPT ); Tue, 28 May 2019 20:25:00 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D33521400F69A; Tue, 28 May 2019 17:24:59 -0700 (PDT) Date: Tue, 28 May 2019 17:24:59 -0700 (PDT) Message-Id: <20190528.172459.2048004424458737029.davem@davemloft.net> To: xuechaojing@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, luoshaokai@huawei.com, cloud.wangxiaoyun@huawei.com Subject: Re: [PATCH net-next] hinic: fix a bug in set rx mode From: David Miller In-Reply-To: <20190527221005.10073-1-xuechaojing@huawei.com> References: <20190527221005.10073-1-xuechaojing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 May 2019 17:25:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xue Chaojing Date: Mon, 27 May 2019 22:10:05 +0000 > in set_rx_mode, __dev_mc_sync and netdev_for_each_mc_addr will > repeatedly set the multicast mac address. so we delete this loop. > > Signed-off-by: Xue Chaojing Applied.