Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5989917ybi;
        Wed, 29 May 2019 00:46:42 -0700 (PDT)
X-Google-Smtp-Source: APXvYqyjvIAMO9ddO7Fok2obz5el/Wxdk0NURtnvcuYgvjeBMVWcadxNRgqzmoXAfShB6gdVxeOp
X-Received: by 2002:a17:90a:c688:: with SMTP id n8mr10538706pjt.29.1559116002854;
        Wed, 29 May 2019 00:46:42 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1559116002; cv=none;
        d=google.com; s=arc-20160816;
        b=GZtjItj51N6bVaivYqNtsMA1g2DYHBjs/bb5WaGn/vfD+ooaQxiq7/4IKw6ptG+Hhf
         LAFoh19qIYuRynmlvgO+ngsv0hjNgc5SijReIV8g70gzMONihOTc5VrtdqF2bcWgT7P6
         OzTCsMZdsfv5yEo6yyqYgZGL48FoKa4jDVr3iAwQEJ+WampyLCKZbYrJYkdDITcoa6O3
         PZdRFp9PHzPhvqOeds7KIzrkB7qLmR72sGrGaTs1mD+fMd93GT8hRepQeTZxbCvN+25k
         5GViSvTu2wyMl4wjvwQdxMBZM2TNKmsamZqjtRTbK38QNHOFNd4U7ZiEXUKHImoHx5kl
         CBeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:organization:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=eR17HjkK+ejt9Bz6W2nVYQfAHHQWg0yBX2fwFDVvHsY=;
        b=INK/goy/jdE3vvKEBxn3P5E//SNOOkIJbIbEQR3tUmAXyKJj8VUxK3ncr+BiXccbpN
         nDGYLKJH5vh6XfMQ19cbq0X+WXk33InozPuotCtk14RWhN8AlNTKKSbtld17U57ErKci
         5rdZsQ9EzL42hVQcrLObWgkz6veMnP1ebIUZSiDfqIFckZeq4wIsnjbw49o//Dx6RbZm
         MBDzOG48ZJyJt70TWvxSTABg6FbL7FfbADubPdTQeL1TTVXM2jnG7pLl+Fg8Dc4T0idP
         ue+ZDPbXmMpVIcE1BbAmWWReWkGlub0QxXfnl7WrBt2ERaZsIexU1JVdf199Utvpb5iU
         yvHA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id d20si23236429pgv.102.2019.05.29.00.46.27;
        Wed, 29 May 2019 00:46:42 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727126AbfE2Ho4 (ORCPT <rfc822;learnos2017@gmail.com>
        + 99 others); Wed, 29 May 2019 03:44:56 -0400
Received: from mga05.intel.com ([192.55.52.43]:13686 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726996AbfE2Ho0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 May 2019 03:44:26 -0400
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 00:44:26 -0700
X-ExtLoop1: 1
Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157])
  by fmsmga001.fm.intel.com with SMTP; 29 May 2019 00:44:23 -0700
Received: by lahna (sSMTP sendmail emulation); Wed, 29 May 2019 10:44:22 +0300
Date:   Wed, 29 May 2019 10:44:22 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     wsa@the-dreams.de, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        benjamin.tissoires@redhat.com, jbroadus@gmail.com,
        patches@opensource.cirrus.com
Subject: Re: [PATCH v3 6/6] i2c: core: Tidy up handling of init_irq
Message-ID: <20190529074422.GW2781@lahna.fi.intel.com>
References: <20190528142900.24147-1-ckeepax@opensource.cirrus.com>
 <20190528142900.24147-6-ckeepax@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190528142900.24147-6-ckeepax@opensource.cirrus.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 28, 2019 at 03:29:00PM +0100, Charles Keepax wrote:
> Only set init_irq during i2c_device_new and only handle client->irq on
> the probe/remove paths.
> 
> Suggested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>