Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6260058ybi; Wed, 29 May 2019 05:24:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFklhR0uDyR44uQVBnUahh0CWRJeeRHKcmfyeSydvieJbiss8w/IQlkWdO8EvzOyVXjjB/ X-Received: by 2002:a62:7fcd:: with SMTP id a196mr100893515pfd.195.1559132693357; Wed, 29 May 2019 05:24:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559132693; cv=none; d=google.com; s=arc-20160816; b=WVSnWEwloarc384YvVzYiWt6zgigNQWunRAxPIr79pNzNDop5HHCo6DiVqJ9VknYrt 1Zjm2PkdekbDegRNzd0Mv6bLlq4+gyqHrUetlMhbxu3Tz4fx8cPYFueIJoyNAI6h6nhW lJlP1d0kUj7/CNtcyeChvQArqh+7SYP46gVRkr/fPeGPpu61R+L1U3l8jKGePCdZWur0 5jgPQYpWGiJcxQNVHdzPXpkSWVNmCn/F+VdC/ZlI6rnl6OBHoEYn4v/bexJIr+0f438H N/LITIDhYvkryD4tIYalgsAOVmIm6rqgQUtEvuJIQDj3h4UFvGbk5ggx3ZVhraBqrI+L 6zkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=3uHyPWQSENyIwHhOem8qjS4qcm0kOphlrSMNf2T+2m0=; b=t62n/RE2jIYvxYbp/eRc9YlOz8rjSD4lnRwDqOHKF0XZzD2bO4KfXZUm5wKobpLzmT KZczMeASyDyCJgY5/nbiixAC1cucgM5RVicd/164w6jZ17LN4R86fQLxQIecknkQZEF/ TYiWP/N+Eah1zzFQITr7FJHjtEpFLZJaYRlLIRkTxOA6TI5IdLe83aBvPZ4pnx+1gzSx pqQIhKOuLifSbqi7+qB/goayP9FGUyexS78mD9sRCQnEsLnX6uZopA7V2AGbLGoKh3fP d8p+KUXFVTcZ8sXk0SuaNdUZhx2Vh7fB3XdN5L4F3DwMjiayd0w5BhXmfkAXf7/UrR6h L/OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j23si26650626pfh.215.2019.05.29.05.24.36; Wed, 29 May 2019 05:24:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfE2MWx (ORCPT + 99 others); Wed, 29 May 2019 08:22:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:35692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726791AbfE2MWx (ORCPT ); Wed, 29 May 2019 08:22:53 -0400 Received: from oasis.local.home (unknown [12.156.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74BF92081C; Wed, 29 May 2019 12:22:51 +0000 (UTC) Date: Wed, 29 May 2019 08:22:48 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org, williams@redhat.com, daniel@bristot.me, Ingo Molnar , Peter Zijlstra , Thomas Gleixner , "Paul E. McKenney" , Matthias Kaehlcke , Frederic Weisbecker , Yangtao Li , Tommaso Cucinotta Subject: Re: [RFC 1/3] softirq: Use preempt_latency_stop/start to trace preemption Message-ID: <20190529082248.76bb7a6c@oasis.local.home> In-Reply-To: <20190529093056.GA146079@google.com> References: <20190529093056.GA146079@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 May 2019 05:30:56 -0400 Joel Fernandes wrote: > Yes, I think so. Also this patch changes CALLER_ADDR0 passed to the > tracepoint because there's one more level of a non-inlined function call > in the call chain right? Very least the changelog should document this > change in functional behavior, IMO. This sounds more like a break in behavior not a functional change. I guess moving it to a header and making it a static __always_inline should be fine though. -- Steve