Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6300905ybi; Wed, 29 May 2019 06:01:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6QepJMT3mew5UrUcfDMsxB7Lm533IMWVUuUq+19wyTE8FlECHVznInIeeIQJgRaJbnUJG X-Received: by 2002:a17:90a:f992:: with SMTP id cq18mr11823484pjb.54.1559134895966; Wed, 29 May 2019 06:01:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559134895; cv=none; d=google.com; s=arc-20160816; b=GMYxpXCkxehVMBbFqO8Vb7hGJfngLnNeXmY9OgutAbQ15FWOXs1D8/gRf9vDj+n26e hBSMG5JcjV3J9WttSkIKYi5K9WMg64lYuSbk7PKbVz/gSduaKGdS6jZ88XtNKUByqDIe YNOPDrMAVLwlGYjPiBucQIYFJPQTL7aIYFywdpTh+zJ4VUNAe94sZbl3QY2R4kJJp2U1 BHY7YaRdfHu/oRdpjttvCTKdZj8wxoB8Qgk483dg4MBDGaHBBxKJgbEL8LZz8h4e31I4 gSFwe3q9KEFMdHXgN68pA6yMYcYVKXED8lv0ZWDHkw6zn4orPrrbXyG/lIC1RRfk/PtQ xxew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=bhQXaLRs/1KnCoWru0HkMcJ3NTv2Aer7zcGpRss3m5U=; b=K9Mz3/j3vMY692cHQRcw6nSq7cnVnVx76qSFWJm3PculaSBkCDYid25jlJA2CA+CJv CxTpqzzbM9uMyYX/XHTFubP1j7Vxi2BJj10CyRhlpWIDeWkYIS5f59i/suwD3wWFpqum 91dXuuFZwg+T/5gXmVmTHA63/X43knY8Yhh8MpsUYtdQ1usmVpJ1EN1YneSZ2xXMISyb VFBpxJU4PVqHG61mHo1XdnaIh1uGHTSYk2JquSSFtpgBwwj2Jap2IDXwfDV/CaDJ1BFq TVQOnwie1Dyrl0IvDR+lEWx+NagRVBCeQ+lDpTeE5OXZ4OJV9OwPwxz1o8puHW/k+3Cr KcIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v35si26383163plg.136.2019.05.29.06.01.19; Wed, 29 May 2019 06:01:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbfE2NAF (ORCPT + 99 others); Wed, 29 May 2019 09:00:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:35156 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726889AbfE2NAF (ORCPT ); Wed, 29 May 2019 09:00:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 962DEAEB7; Wed, 29 May 2019 13:00:03 +0000 (UTC) Date: Wed, 29 May 2019 12:59:59 +0000 From: Michal Rostecki To: Sergei Shtylyov Cc: Michal Rostecki , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf] libbpf: Return btf_fd in libbpf__probe_raw_btf Message-ID: <20190529125959.GA31842@wotan.suse.de> References: <20190529082941.9440-1-mrostecki@opensuse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 12:53:42PM +0300, Sergei Shtylyov wrote: > Hello! > > On 29.05.2019 11:29, Michal Rostecki wrote: > > > Function load_sk_storage_btf expects that libbpf__probe_raw_btf is > > returning a btf descriptor, but before this change it was returning > > an information about whether the probe was successful (0 or 1). > > load_sk_storage_btf was using that value as an argument to the close > > function, which was resulting in closing stdout and thus terminating the > > process which used that dunction. > > Function? :-) Opps! I will fix in v2. Thanks!