Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6365277ybi; Wed, 29 May 2019 06:52:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqws/dmzTadW69LxYYRH3RyVziIfIE/6cgpwQX/qAaUi6KXSqW6MGX4j2C2foMZ9hQqwiBA/ X-Received: by 2002:a62:3741:: with SMTP id e62mr55568910pfa.213.1559137920681; Wed, 29 May 2019 06:52:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559137920; cv=none; d=google.com; s=arc-20160816; b=ZpdEB22JLzl5LyhqnWnSSUKaSb0nugu9bOo3rhbrgQqzn3JveTKDxnvyOCtp2GlWH6 /aVREqqokdscaS++lI4kyhzjTHWRKRYa6zKW5mF0WGG1pa4q98L2EnJljgL2FQni1SqK ZbJhvzXcgY2xu9vCKYLjZ1E1l4TTpP5yyGGzMq1DUsBanxc9BTziF45f8WtnkA68jawZ PtFm2LA/qGPZ6zcU8doS2bAl39ET1zP2gGS4d8FBLUHAdMqg1Hous2SOPSMY0DLkE31U sWIDJRpy/p0QbzLgUBPGAYtSnCokkqg0nZlKpmsT9MXtqWY6nA/J6JyukrtsZkIwKrGv UvPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YZ+pg8aR5qtYQVgChplcfMUX8pIrRvMgQQ9ehzYO2NY=; b=Hk5zw3xM1BU4aLqDJEblg03OhcfVcMhfw/ZUOhDjy5b6c5rzmWnJGTyGXqY9A/xh9P 6X48cleMS0E8K06ALdDap88BV1ELBa4znB4Zr+cFTJtt40mcLrLEMVQUkG8imGhIjUIf q4Xd+Mu8yoMg//S+0aVH0gYrFEk7ZzpE/Ag+qdycF9mAuDdo7Co3w2DOo54z1R3YRrDx a+3joEKY83RDt4c2M6pmsde6MNaP+uciZk4AaDFDRnsUfqtnY5KRYEnsP2ZSDIqzRHoV Y1VIXpOzY8gXHmwDOYIjKvDhdAs14PCGWfpQOwiMz4cLv+IxMceUFoMx2wN4YM6vyJav rphA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=Gv0ccnGU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si6229294pls.31.2019.05.29.06.51.43; Wed, 29 May 2019 06:52:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=Gv0ccnGU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727246AbfE2Nu1 (ORCPT + 99 others); Wed, 29 May 2019 09:50:27 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:41616 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726702AbfE2Nu1 (ORCPT ); Wed, 29 May 2019 09:50:27 -0400 Received: by mail-qt1-f196.google.com with SMTP id s57so2613394qte.8 for ; Wed, 29 May 2019 06:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YZ+pg8aR5qtYQVgChplcfMUX8pIrRvMgQQ9ehzYO2NY=; b=Gv0ccnGUxwVA4CTo/MYZhnLEFa+NMtfNA1dXp7D65wkDSPkL7/+ggsF0C/UDeGkJGC gVMx9cP8UCjFB82NPeXC1HyYatRf7zEYiMfEd90UB8H6ubBRiYwnOVjyjfxrmFB64EJS 459UY3oBceABLZ7+b1T19Ucuh58Xu2owPXLhWWP6WrdovjznYkXFl/EKJKNXoPu/OYeV 6PjCnVolGMPeGhOdaTq/q1Yyfy+stN9uS68Ti3umLmlPH/SeYdHT+3J09kv+fqDOcipY REDPY83if8k2P3r22QjZc0VBnbYLOIdhe5OWvzlpzcqPMuBR/WYmypooktiqqy3WDP9o 7wFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YZ+pg8aR5qtYQVgChplcfMUX8pIrRvMgQQ9ehzYO2NY=; b=M/Fq/n3MGt87lkAZZiG5x07rluYLDNfyS97V1aBGJbiWIcC0EtQKiB1KLZ2hFKBVWM jNKKqZqAKAoLijMyyQjyqs3zU02SSd8mxXIUvDkAv/qoemNiCSzh/WVo2SO/a6BZMd7e Fim8BGElRBBt5EyIR9yy8x7/PKa/H3VoU418NEbLbbBhPWOR+mpWirNwpi2N1BxjhtZE Cf4p7sSJE2ZOWeIYHRlVSjFs7AVYZWM0YXEYsMnnmyVeTyBsJ3gJ6qKUhECVx0/Wre6a +PeK4yLrL5K+YpEYXBw7xKQQ+S14N75uIGMeMsOqcjLpTmAzyHpaGJMBFHz/ixzfrdj/ ph/A== X-Gm-Message-State: APjAAAW5CDQVCa/e1c+UYjxSjfYdXh6Z/J45upDEQtJEXPeo1oHHev4H pOc0UGcfIYYEjDJhz9olKY4/4w== X-Received: by 2002:a0c:d13a:: with SMTP id a55mr58174644qvh.111.1559137821888; Wed, 29 May 2019 06:50:21 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::d8f]) by smtp.gmail.com with ESMTPSA id n26sm739941qtn.36.2019.05.29.06.50.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 06:50:20 -0700 (PDT) Date: Wed, 29 May 2019 09:50:19 -0400 From: Josef Bacik To: xiubli@redhat.com Cc: josef@toxicpanda.com, axboe@kernel.dk, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, atumball@redhat.com Subject: Re: [PATCH] nbd: fix crash when the blksize is zero Message-ID: <20190529135018.6vbhxkuyppctqtco@MacBook-Pro-91.local> References: <20190527054438.13548-1-xiubli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190527054438.13548-1-xiubli@redhat.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 27, 2019 at 01:44:38PM +0800, xiubli@redhat.com wrote: > From: Xiubo Li > > This will allow the blksize to be set zero and then use 1024 as > default. > > Signed-off-by: Xiubo Li Hmm sorry I missed this somehow Reviewed-by: Josef Bacik Thanks, Josef