Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 May 2019 09:11:45 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Matt Helsley <mhelsley@vmware.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool
 conversion
Message-ID: <20190529141145.4tycu25a3os3fpgr@treble>
References: <cover.1558569448.git.mhelsley@vmware.com>
 <20190528144328.6wygc2ofk5oaggaf@treble>
 <20190529134152.GX2623@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190529134152.GX2623@hirez.programming.kicks-ass.net>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 29, 2019 at 03:41:52PM +0200, Peter Zijlstra wrote:
> On Tue, May 28, 2019 at 09:43:28AM -0500, Josh Poimboeuf wrote:
> > Would it be feasible to eventually combine subcommands so that objtool
> > could do both ORC and mcount generation in a single invocation?  I
> > wonder what what the interface would look like.
> 
> objtool orc+mcount ?
> 
> That is, have '+' be a separator for cmd thingies. That would of course
> require all other arguments to be shared between all commands, which is
> currently already so, but I've not checked the mcount patches.

The problem is that you have to combine "orc generate" with "mcount
record".  Because even the subcommands have subcommands ;-)

And also sharing arguments between all subcommands isn't ideal.

Maybe could do:

  objtool orc generate [orc options] + mcount record [mcount options]

> Alternatively, we ditch the command thing entirely and live off of pure
> flags:
> 
>  'o', "orc", "Generate ORC data"
>  'c', "mcount', "Generate mcount() location data"

-- 
Josh