Date: Wed, 16 Nov 2005 10:00:53 -0800
From: Andrew Morton <akpm@osdl.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: theonetruekenny@yahoo.com, linux-kernel@vger.kernel.org
Subject: Re: mmap over nfs leads to excessive system load
Message-Id: <20051116100053.44d81ae2.akpm@osdl.org>
In-Reply-To: <1132163057.8811.15.camel@lade.trondhjem.org>
References: <20051116150141.29549.qmail@web34113.mail.mud.yahoo.com>
	<1132163057.8811.15.camel@lade.trondhjem.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1809
Lines: 56

Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> On Wed, 2005-11-16 at 07:01 -0800, Kenny Simpson wrote:
> > --- Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > > Anyhow, does the following patch help?
> > 
> > Unfortunately, not:
> > 
> > samples  %        symbol name
> > 545009   15.2546  find_get_pages_tag
> 
> Argh... I totally missed the point there with the last patch. We should
> be resyncing the page tag with the value of the PG_dirty flag...
> 
> OK, please back out the patch that I sent you, and try this one instead.
> 
> ...
> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 8f71e76..61ec355 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -213,6 +213,7 @@ static int nfs_writepage_sync(struct nfs
>  	} while (count);
>  	/* Update file length */
>  	nfs_grow_file(page, offset, written);
> +	clear_page_dirty_tag(page);
>  	/* Set the PG_uptodate flag? */
>  	nfs_mark_uptodate(page, offset, written);
>
> ....  
> +int clear_page_dirty_tag(struct page *page)
> +{
> +	struct address_space *mapping = page_mapping(page);
> +
> +	if (mapping) {
> +		unsigned long flags;
> +
> +		write_lock_irqsave(&mapping->tree_lock, flags);
> +		if (!PageDirty(page))
> +			radix_tree_tag_clear(&mapping->page_tree,
> +						page_index(page),
> +						PAGECACHE_TAG_DIRTY);
> +		write_unlock_irqrestore(&mapping->tree_lock, flags);
> +	}
> +}

That will fix it, but the PageWriteback accounting is still wrong.

Is it not possible to use set_page_writeback()/end_page_writeback()?

Are these pages marked "unstable" at this time?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/