Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6464511ybi; Wed, 29 May 2019 08:12:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwdW1zZFAfIHeuYtmnCU432wnpAxpRELVc/9k5E5tSrx401hRm2Az/BmpD3ndAuxe9Wyrvz X-Received: by 2002:a65:56cb:: with SMTP id w11mr119298273pgs.236.1559142772331; Wed, 29 May 2019 08:12:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559142772; cv=none; d=google.com; s=arc-20160816; b=NQ4lXXWhEDgAVCVhebKA2gJ5L3qgXZRrKqtaYkDCtJtHLO2XIFCPe98R9u0lS94ZcT ZnXJjQy1y2lysu7PcP/ijS5aeOkiZ9nsLJi8bHl57riQSGswqiz/6qnAvwOPD4IbSIvv 3lIQlJzALEa2h5XzHLjbYY7hJ/5r8MMwZjZUykzAAcQDjtFztvkc8w2gu+lLazgnUXWk 8Z8vBQlgCvWWZlphBWzjB2eIyuuVp6DcL+arfmiZf/+nbXy5U+/JTHnSM7+sW4VgNdKy 6E6jTTfMNkdcabnBa5SePxsIUWLirimtD1dPMn+xFWkTk2kzp75l+jUnSzNNDp2gpuzT BkdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=HhDTy9sjN1NrkqmkfONzOVSCWXHZo6XKTxadGWsSlGg=; b=f4upXfnDk8rN5kWlUYKsG51gimffrp4yZkwDQTWmLPBPT8W4lGb/gYfZ7t3lMhUCQR vcwd04hdn/yV0nZNK+b03uvaAlbsNkcNchF79ujf0pMa8xqB3arCcPXzJYtCMH8xUxKQ WOe+MqOEgYmJCt2LWjcfagO9AUXTjhufPv317sjLsoXAJusbBnp+9fMme27Mn/gHKJra 5I4IgWU7AbL6EK5u1mFjTHuzYTQxWpAA9qsENxjKQzBHr5CgE1IsWrk+6oi3JP6R7otD DomOx8sxhsjEWBFnSk5oS4z09c27VEQCag5qlPqp3+5Yh33L38wkYQtXIPj5E8Slck// 90pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11si7491117pjn.72.2019.05.29.08.12.34; Wed, 29 May 2019 08:12:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726699AbfE2PJO (ORCPT + 99 others); Wed, 29 May 2019 11:09:14 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbfE2PJO (ORCPT ); Wed, 29 May 2019 11:09:14 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C65A341; Wed, 29 May 2019 08:09:13 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 342A03F5AF; Wed, 29 May 2019 08:09:12 -0700 (PDT) Date: Wed, 29 May 2019 16:09:09 +0100 From: Will Deacon To: Sami Tolvanen Cc: Catalin Marinas , Mark Rutland , Kees Cook , Nick Desaulniers , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] fix function type mismatches in syscall wrappers Message-ID: <20190529150909.GE11154@fuggles.cambridge.arm.com> References: <20190524221118.177548-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524221118.177548-1-samitolvanen@google.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 03:11:15PM -0700, Sami Tolvanen wrote: > These patches fix type mismatches in arm64 syscall wrapper > definitions, which trip indirect call checks with Control-Flow > Integrity. > > Changes in v3: > - instead of SYSCALL_DEFINE0, just define __arm64_sys_ni_syscall > with the correct type to avoid unnecessary error injection Thanks, I've picked this up for -rc3. Will