Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6468633ybi; Wed, 29 May 2019 08:15:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjZk7HGZ6D0MnY6WEPBFOLGD0i644tP6FjtZ1zpoQzK/el/PovFHhrp+tZ+O3xy1kvcBCp X-Received: by 2002:a17:902:44a4:: with SMTP id l33mr45449638pld.337.1559142954664; Wed, 29 May 2019 08:15:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559142954; cv=none; d=google.com; s=arc-20160816; b=UQPXTn/iawldQR87JQXUZKgoYt/X921+YddfCyYCmFbtNEcGbc5lFgM0fT1bvDQGY2 MMdkUaVIeFnOGfyZrS4KiLSgX/DubeUNLyuo+6m2fME+3notKgjlunqObj10TW0PoOWi N3Z1xq2EO74o4XMdK6u9t/TL/3ylLfT+ep26ehGsiFoMJL5AGaRJT3I9G3x4decrey0d ip3/fu7mTC4JN3ER8c3gqWSQdLSEnwENHyxtlttq6nuERSPLjKYVPTYS8wzCgEveU8jb 19pLopsTpzyVkmLr6mca33j2Hw5IjsYjYdpULyoDmp510+oFvHana9ILwGCt8enK6eJx eTYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uFR4M/qYJrlfoivRwBUnVxWV5fsy3IwQQxYYkoWmhno=; b=SicgdnaYDMdYGb2mV2ajOaJ3o0J5KVgIZFbJwwV1KJO+mmklqwK3u9XD0mVD9Fig8T akjOxG3AG70zPt0pYHAoKMM0VSPD77SKWlvxR+JsZutsbVs78BJzR37fW0jSghSkP5f4 KpM1Nd2qE5W+C140lWEEbhVYcrZ9Vhpe6xR8mh9N5PObR0h/2os8ZVvy4Y3/p4ortSm/ NURYllAXhtzUZLu/Z7Te7e1pU8532I/kvkzwZe8LbmRzpHZ8NDQ+kQJeGxoRsnGODspc zSzpPRMnz9BC/OBSk5TGmk1/CrrYdmA7z6hOxm4QXTGpYoNghWcUQNhTN2KuaK3vNDfc xfaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si26098744pgm.86.2019.05.29.08.15.08; Wed, 29 May 2019 08:15:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfE2PMc (ORCPT + 99 others); Wed, 29 May 2019 11:12:32 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47880 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbfE2PMc (ORCPT ); Wed, 29 May 2019 11:12:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86AA8341; Wed, 29 May 2019 08:12:31 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FC923F5AF; Wed, 29 May 2019 08:12:30 -0700 (PDT) Date: Wed, 29 May 2019 16:12:27 +0100 From: Will Deacon To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linux Containers , Oleg Nesterov , linux-arch@vger.kernel.org, Dave Martin , James Morse Subject: Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL Message-ID: <20190529151227.GF11154@fuggles.cambridge.arm.com> References: <20190523003916.20726-1-ebiederm@xmission.com> <20190523003916.20726-4-ebiederm@xmission.com> <20190523101702.GG26646@fuggles.cambridge.arm.com> <875zq1gnh4.fsf_-_@xmission.com> <20190523161509.GE31896@fuggles.cambridge.arm.com> <8736l4evkn.fsf@xmission.com> <20190524100008.GE3432@fuggles.cambridge.arm.com> <87o93rcwee.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o93rcwee.fsf@xmission.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 05:36:41PM -0500, Eric W. Biederman wrote: > Will Deacon writes: > > > On Thu, May 23, 2019 at 03:59:20PM -0500, Eric W. Biederman wrote: > >> Will Deacon writes: > >> > >> > On Thu, May 23, 2019 at 11:11:19AM -0500, Eric W. Biederman wrote: > >> >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > >> >> index ade32046f3fe..e45d5b440fb1 100644 > >> >> --- a/arch/arm64/kernel/traps.c > >> >> +++ b/arch/arm64/kernel/traps.c > >> >> @@ -256,7 +256,10 @@ void arm64_force_sig_fault(int signo, int code, void __user *addr, > >> >> const char *str) > >> >> { > >> >> arm64_show_signal(signo, str); > >> >> - force_sig_fault(signo, code, addr, current); > >> >> + if (signo == SIGKILL) > >> >> + force_sig(SIGKILL, current); > >> >> + else > >> >> + force_sig_fault(signo, code, addr, current); > >> >> } > >> > > >> > Acked-by: Will Deacon > >> > > >> > Are you planning to send this series on, or would you like me to pick this > >> > into the arm64 tree? > >> > >> I am planning on taking this through siginfo tree, unless it causes > >> problems. > > > > Okey doke, it would just be nice to see this patch land in 5.2, that's > > all. > > As this does not appear to have any real world consequences I am aiming > at 5.3. If someone else would like to take it and feed it to Linus > sooner I won't object. Thanks. I've picked this patch up as part of the arm64 fixes I plan to send for -rc3. Will