Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6468818ybi; Wed, 29 May 2019 08:16:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGyoXXYonDbOdP+JPL0g4nbD8x0+26iL1VPrlDxaT+PcI75ktQJCWhhn/cxUC1SGofQYPr X-Received: by 2002:a17:902:363:: with SMTP id 90mr142344856pld.131.1559142964349; Wed, 29 May 2019 08:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559142964; cv=none; d=google.com; s=arc-20160816; b=vyT+h9ooG+O0iv1LvQEUL7eF8Otggbyz+9mE8aPJtPvbhxqpG1qeZqnrKyNJ7JMVkV ATUSOp2jgFShciH9i/zG1q+UlSaHtBGAhNgidruTqr84qgGMm2WJOWYtLW668nDcA9a9 TnP5Np5LxvwQrnxKLKxP2dUNyKbnA+pZtxLeue/HDmxaNUdBQkmgXlnTIeo02qD91/wP zSNy08NhHKNXTRqjWUXSSAx1gXHYjeIRI7wgPo29JRHrQb1K9sjfmtN39OZuuhOUj6se ZAXmnDfUEH+ybdsXQxowsgX6zS4rtnaT5MV4hYuv1LPu5eGw/9Vn21V5xR5UfQOk7o/d imwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=cJ7eHFh7fQl2WTIDm868Jdv9NxijLPZrJNxg0BI16tM=; b=BZBF40QAK8fYnBvgz+MypZN7ywxEPQqMCSj+goPFL2b+Wtchn33R3eW635wu0NbvAe PEneNBkA4SgAHidBknkKmE5GJCpTxSIhx012C+IDO08eRN5ecMeiSv0P3F1gbMun6ar4 1MBEfCuvF8FzQ3GVLNYrb3CSFHvaHvnufIW9q0xHpqb8z4/Olg2GRHYO3XJrkxHjRC8n cpZ3p5Ou+M5UrLkxaMSltDzeVdM/WOavw9M1oWaO5fUeVfVHZUbkmIjqybYri34rEDIF svjUoTCck/9UDxXewPqWsQczHdvmggtLhvTf2/5NhkFj5xxl2XMMISXOpWqY2heiSqeI 7BuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 36si7846301pla.80.2019.05.29.08.15.47; Wed, 29 May 2019 08:16:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbfE2PNH (ORCPT + 99 others); Wed, 29 May 2019 11:13:07 -0400 Received: from foss.arm.com ([217.140.101.70]:47912 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbfE2PNF (ORCPT ); Wed, 29 May 2019 11:13:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91E53341; Wed, 29 May 2019 08:13:04 -0700 (PDT) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EFAB3F5AF; Wed, 29 May 2019 08:13:03 -0700 (PDT) Subject: Re: [PATCH 12/21] EDAC, ghes: Add support for legacy API counters To: Robert Richter Cc: Borislav Petkov , Tony Luck , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190529084344.28562-1-rrichter@marvell.com> <20190529084344.28562-13-rrichter@marvell.com> From: James Morse Message-ID: <92eda11f-dad9-bb2b-3a87-80b6c8d8e228@arm.com> Date: Wed, 29 May 2019 16:13:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190529084344.28562-13-rrichter@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, On 29/05/2019 09:44, Robert Richter wrote: > The ghes driver is not able yet to count legacy API counters in sysfs, > e.g.: > > /sys/devices/system/edac/mc/mc0/csrow2/ce_count > /sys/devices/system/edac/mc/mc0/csrow2/ch0_ce_count > /sys/devices/system/edac/mc/mc0/csrow2/ch1_ce_count > > Make counting csrows/channels generic so that the ghes driver can use > it too. What for? Is this for an arm64 system? Surely we don't have any systems that used to work with these legacy counters. Aren't they legacy because we want new software to stop using them! Thanks, James