Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6629459ybi; Wed, 29 May 2019 10:31:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYi+tQm5P+l795MAEeavObT7D/if+dFadA4Oem17+utFV1FaqpykjyBRriM+Vm0qsg4g8I X-Received: by 2002:aa7:9dc9:: with SMTP id g9mr114454770pfq.228.1559151087043; Wed, 29 May 2019 10:31:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559151087; cv=none; d=google.com; s=arc-20160816; b=cPKlERUCowDEnxbmW8GtXUMMLf62nO2GxHyZNI1uG6lSWuwiA0LDetIbdLMVjzWWFl WT3P+QLHkVlrHjYajbN9VAvFObNea5Wx1ZO4TYZJz3lcp9Ok/UKzu7xfJK8LnflgEAsC VxvKWIEFMIAd+j9fCjbRFM+et8M3i2Dl3rXN29OwaZOSgtcFdD/KflAyJza2YsLcG+pN NOjX7vSlk+KJ+GKI+aswR70trGHS6rspkM/2Vsj0Nw5P+zqKJE2PQFMs3dPjBGWfigJx EacmmoVkWIKODPL0wj2H6lqqzjBPk6bGmAzpXImLogH+UpLjpkh4Tohukf0rcpXWVXhl Dq4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=SSjuAfwTz5QHQHE4Kf0aqfNoRtUVCzBQ+xmkW2wKTno=; b=03oJfc7CwJwDTDOON0C49/bW5uzS0WBHCAaB5sqQ1IVjRZM0UQjH/HrfgRkCAh4hGj 5+dN5c0eYMck2tEvbSzlcXZwl+jsuPH30N/v/UDzljmTSWrz7f10bB35DHb0zYaNY5Uy urH+zgxcvCG71vBAoz5M5Bsi3iXl2FCiiA/JQZDXO7xtud3m4gH5goOIYYGsreeCquTo AJPcorsXj4De9qfDloDlBk5d1usJnpGeYot2nqtRHUC0/3iW4EFJul2Aht840MIOK1bT tYmho6xDY6Gg+sVIEQXXbDvPOifAM8sKG8/nyxIVguP46PGTKV4u8Qzuc2nZ4GCuaddK Fbgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UF8RXpJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5si376440pgs.4.2019.05.29.10.31.10; Wed, 29 May 2019 10:31:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UF8RXpJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbfE2R3y (ORCPT + 99 others); Wed, 29 May 2019 13:29:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:33414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbfE2R3y (ORCPT ); Wed, 29 May 2019 13:29:54 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1821323F98; Wed, 29 May 2019 17:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559150994; bh=GjeXbG5a4/TCvqedsRpiu3Uwp6Fw3Us0T1y7WfWByvU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UF8RXpJDjkY3rMBsElIE5D9QiCUeq99CA5mfV96q7RfqwKoqR0GQ9Kdu5U7CEeXxh 81NE9muFdMl2wt0cnXbVHV7cQTjKpfxGqOon9bggH/Lye5cIX3pwc1dQVVV59/RXWT sgQf0yEYeKB9fQ8ob2UXnlaDVz9vqXEZwI99yWbU= Date: Wed, 29 May 2019 19:29:49 +0200 (CEST) From: Jiri Kosina To: Josh Poimboeuf cc: "Rafael J. Wysocki" , Pavel Machek , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume In-Reply-To: <20190529171726.obom7xql72bgbjhc@treble> Message-ID: References: <20190529161028.a6kpywzpjazgql5u@treble> <20190529171726.obom7xql72bgbjhc@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 May 2019, Josh Poimboeuf wrote: > I still have the question about whether we could make mwait_play_dead() > monitor a fixed address. If we could get that to work, that seems more > robust to me. Hmm, does it really? That'd mean the resumer and resumee must have the same fixmap. How are you going to guarantee that? Currently the resuming kernel doesn't really have to be the same as the one that is being resumed. > Another question. With your patch, if booted with nosmt, is SMT still > disabled after you resume from hibernation? Yup, it is. > I don't see how SMT would get disabled again. The target kernel only onlines the CPUs which were online at the time of hibernation (and are therefore in frozen_cpus mask). -- Jiri Kosina SUSE Labs