Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6845017ybi; Wed, 29 May 2019 14:16:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwqfnKaQN4WXAakpnsAv+H5LzQpoXSrNJMT4ZaTeomU3C1I0D9yDQWAIdRkqa8WXw+1aiiL X-Received: by 2002:a17:90a:1959:: with SMTP id 25mr15174276pjh.113.1559164609755; Wed, 29 May 2019 14:16:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559164609; cv=none; d=google.com; s=arc-20160816; b=SapLQ2DBw2dLOrmuCi9MMLXrx0dPF6ohy68Ki3scYp1jMINCNSapVcJzMREmd487wm Nuj9a8ddUaM/HRsixLMODUeRxN5FwGFIsxiEK0qexvSI4cEqe2uE/AzEKSBhV+L67x3o gbOH72wbJgKtvwekNLqQA0cqmkPMXZQxuXAMTSpSEcEud7NOrMTIgu5xiuXq7uIJC5NY tobw8WFOCXA/eQ3tWU43BvELz8b+Oig+6OJX/vRQJSpA8QjWDGezeqkgYSSF668WCgj8 99UgEeBVBuYf564VQavnoTnEVnFUzfLzBLOLo2IFnVjaR9Qu6Rwf+7pXI1QbgkqLv2WR aeaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=osu/x7FYody2Hoq4uLkPS7Kf2axeOtjhm45H0GWnEgQ=; b=x8Yfz3hO3xcJbU58A9+TvGbj49sDdwOgUW979rQwSL3IYtyUgar9Cn4pbb7LyQhObJ xSuuqvgmjCk7xmAz2U71L+k+3lbsUqWFsp16+v6STiSIaV0jLCUdseQqUYqQA+v1upei oBZSIlGlZVoyzildOSjpLpJdaX5jeJYR3BSnPOpNknf54o8qkdNzc05Paa0t2W+0CLti 2FdQ2dgDzdZaqL32fWbEHZGBVMzYQJoOUVE81NnqhAy7NDiEevxWi1SQhzHMqJ77ZMCf h8iHS0CeiTjQMTs3TDiAwG4rA+MvVYRhy52V1nKxsUNuecdKDQ+408smamTwSQTO3GUb eLkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Q6iFvgkj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si753851plp.223.2019.05.29.14.16.27; Wed, 29 May 2019 14:16:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Q6iFvgkj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfE2VNV (ORCPT + 99 others); Wed, 29 May 2019 17:13:21 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:34839 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfE2VNV (ORCPT ); Wed, 29 May 2019 17:13:21 -0400 Received: by mail-pl1-f195.google.com with SMTP id p1so1584513plo.2 for ; Wed, 29 May 2019 14:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=osu/x7FYody2Hoq4uLkPS7Kf2axeOtjhm45H0GWnEgQ=; b=Q6iFvgkjVosWfknWr+UHUu0tmky9zm33+DXECZJslVHVhgXMsWHIDiQZUWXntUatCA gtYtKge8bQKNw1zPDJ0JxtkDBeLOpk3n788p8jLzboez7cOBdOk3xMXVZZPGpxyS3x9K +Uae5F7tOGpwhfcoxXyxW9GrTiMJP+LtO4R7t7p84TuVCE5nj5cKaDb3THXzC3kIsMSO io4gJPe2eByMBwXK8RaTcVVnnCWsrJWs+ZmBy1Y71cXlPSbo70tjOnP6CFlK+yP2SeY8 Uzz2631SlXTf5bRFwZcUyeYsXMkgfBtrNwaHVgCJ3IUlahWRyBWs6lNAckn6GmoeAOfu R2mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=osu/x7FYody2Hoq4uLkPS7Kf2axeOtjhm45H0GWnEgQ=; b=A49oo0jNVgYdhojyrByJTkQ+cLkWG6a68uUl9F/Cx3yeYauMb1ElexK5rs8uDr6q/V eCx1uUjVHWfzdqa6VJuyNFqa84QWQp+VfkVg28o7dxsiWUXDaOIB++5AjLGmbm4bhY1t DfNEhaPwTOvYScb/9iu7JbzmeZTQ/j2K4A1qCbdGGoZ1Sc0O5ruoUruqwLUOnv/evxCL TQ2ZvC4O4/jsKSBdzrqESUU3f+agnI2I2mo5IvVVBXLtzTFx43e768PdMhQOQs5JCXJD f6gSoYF61d0ITOSwOYxFmhQbTjykTFLdBrf3FeiD553VzSumtbuacnwOvA7n5PgA7OnU qbcQ== X-Gm-Message-State: APjAAAWf73b9jaawWIT4NzIP1zDK0WAIz8zNZucm8C8efMiobBHO56gM BWI9+qw8BDUnsZgw5whISA/jow== X-Received: by 2002:a17:902:a508:: with SMTP id s8mr123754339plq.186.1559164400332; Wed, 29 May 2019 14:13:20 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id 80sm584101pfv.38.2019.05.29.14.13.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 14:13:19 -0700 (PDT) Date: Wed, 29 May 2019 14:13:18 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Hariprasad Kelam , Ondrej Zary cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL In-Reply-To: <20190529175851.GA10760@hari-Inspiron-1545> Message-ID: References: <20190529175851.GA10760@hari-Inspiron-1545> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 May 2019, Hariprasad Kelam wrote: > dont acquire lock before calling wd719x_chip_init. > > Issue identified by coccicheck > > Signed-off-by: Hariprasad Kelam > ----- > changes in v1: Replace GFP_KERNEL with GFP_ATOMIC. > changes in v2: Call wd719x_chip_init without lock as suggested > in review Why was host_lock taken here initially? I assume it's to protect some race in init that leads to an undefined state.