Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1559171394.git.mchehab+samsung@kernel.org> <c8f6ddd2d538e36f6036681f5756f6ea9499039f.1559171394.git.mchehab+samsung@kernel.org>
In-Reply-To: <c8f6ddd2d538e36f6036681f5756f6ea9499039f.1559171394.git.mchehab+samsung@kernel.org>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Thu, 30 May 2019 02:26:44 +0300
Message-ID: <CA+h21hqtfh1KTZXXC+Hmf7JUkXpWwjtJU_KS_u-wcjnWA3pLZA@mail.gmail.com>
Subject: Re: [PATCH 21/22] docs: net: sja1105.rst: fix table format
To:     Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc:     Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 May 2019 at 02:24, Mauro Carvalho Chehab
<mchehab+samsung@kernel.org> wrote:
>
> There's a table there with produces two warnings when built
> with Sphinx:
>
>     Documentation/networking/dsa/sja1105.rst:91: WARNING: Block quote ends without a blank line; unexpected unindent.
>     Documentation/networking/dsa/sja1105.rst:91: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> It will still produce a table, but the html output is wrong, as
> it won't interpret the second line as the continuation for the
> first ones, because identation doesn't match.
>
> After the change, the output looks a way better and we got rid
> of two warnings.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
>  Documentation/networking/dsa/sja1105.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/networking/dsa/sja1105.rst b/Documentation/networking/dsa/sja1105.rst
> index ea7bac438cfd..cb2858dece93 100644
> --- a/Documentation/networking/dsa/sja1105.rst
> +++ b/Documentation/networking/dsa/sja1105.rst
> @@ -86,13 +86,13 @@ functionality.
>  The following traffic modes are supported over the switch netdevices:
>
>  +--------------------+------------+------------------+------------------+
> -|                    | Standalone |   Bridged with   |   Bridged with   |
> -|                    |    ports   | vlan_filtering 0 | vlan_filtering 1 |
> +|                    | Standalone | Bridged with     | Bridged with     |
> +|                    | ports      | vlan_filtering 0 | vlan_filtering 1 |
>  +====================+============+==================+==================+
>  | Regular traffic    |     Yes    |       Yes        |  No (use master) |
>  +--------------------+------------+------------------+------------------+
>  | Management traffic |     Yes    |       Yes        |       Yes        |
> -|    (BPDU, PTP)     |            |                  |                  |
> +| (BPDU, PTP)        |            |                  |                  |
>  +--------------------+------------+------------------+------------------+
>
>  Switching features
> --
> 2.21.0
>

Acked-by: Vladimir Oltean <olteanv@gmail.com>