Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1559004795-19927-1-git-send-email-wanpengli@tencent.com>
 <1559004795-19927-3-git-send-email-wanpengli@tencent.com> <D119BC9B-3097-4453-BC17-5AE532EDB995@oracle.com>
In-Reply-To: <D119BC9B-3097-4453-BC17-5AE532EDB995@oracle.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Thu, 30 May 2019 09:09:52 +0800
Message-ID: <CANRm+Cx4egTwvbwwrS0Mi23QmesFDY+DkBAgVsC67o4ea3tYTg@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] KVM: X86: Implement PV sched yield hypercall
To:     Liran Alon <liran.alon@oracle.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 29 May 2019 at 20:28, Liran Alon <liran.alon@oracle.com> wrote:
>
>
>
> > On 28 May 2019, at 3:53, Wanpeng Li <kernellwp@gmail.com> wrote:
> >
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > The target vCPUs are in runnable state after vcpu_kick and suitable
> > as a yield target. This patch implements the sched yield hypercall.
> >
> > 17% performace increase of ebizzy benchmark can be observed in an
> > over-subscribe environment. (w/ kvm-pv-tlb disabled, testing TLB flush
> > call-function IPI-many since call-function is not easy to be trigged
> > by userspace workload).
> >
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> > Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> > ---
> > arch/x86/kvm/x86.c | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index e7e57de..2ceef51 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -7172,6 +7172,26 @@ void kvm_vcpu_deactivate_apicv(struct kvm_vcpu *=
vcpu)
> >       kvm_x86_ops->refresh_apicv_exec_ctrl(vcpu);
> > }
> >
> > +void kvm_sched_yield(struct kvm *kvm, u64 dest_id)
> > +{
> > +     struct kvm_vcpu *target;
> > +     struct kvm_apic_map *map;
> > +
> > +     rcu_read_lock();
> > +     map =3D rcu_dereference(kvm->arch.apic_map);
> > +
> > +     if (unlikely(!map))
> > +             goto out;
> > +
>
> We should have a bounds-check here on =E2=80=9Cdest_id=E2=80=9D.

Yeah, fix it in v3.

Regards,
Wanpeng Li