Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH] nbd: set the default nbds_max to 0
To:     Josef Bacik <josef@toxicpanda.com>
Cc:     axboe@kernel.dk, nbd@other.debian.org, mchristi@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        atumball@redhat.com
References: <20190529080836.13031-1-xiubli@redhat.com>
 <20190529134834.t6qjq2nkut37zpsf@MacBook-Pro-91.local>
From:   Xiubo Li <xiubli@redhat.com>
Message-ID: <63658620-7d1f-f626-b637-8f551ca07f95@redhat.com>
Date:   Thu, 30 May 2019 09:22:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190529134834.t6qjq2nkut37zpsf@MacBook-Pro-91.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/5/29 21:48, Josef Bacik wrote:
> On Wed, May 29, 2019 at 04:08:36PM +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> There is one problem that when trying to check the nbd device
>> NBD_CMD_STATUS and at the same time insert the nbd.ko module,
>> we can randomly get some of the 16 /dev/nbd{0~15} are connected,
>> but they are not. This is because that the udev service in user
>> space will try to open /dev/nbd{0~15} devices to do some sanity
>> check when they are added in "__init nbd_init()" and then close
>> it asynchronousely.
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>
>> Not sure whether this patch make sense here, coz this issue can be
>> avoided by setting the "nbds_max=0" when inserting the nbd.ko modules.
>>
> Yeah I'd rather not make this the default, as of right now most people still
> probably use the old method of configuration and it may surprise them to
> suddenly have to do nbds_max=16 to make their stuff work.  Thanks,

Sure, make sense to me :-)

So this patch here in the mail list will as one note and reminder to 
other who may hit the same issue in future.

Thanks.
BRs
Xiubo


> Josef
>