Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp160298ybi; Wed, 29 May 2019 18:44:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxwaEgmyizt5jDeqlo7MNdR1gnmaLSn4twPBq0v9X9dtq1FDHtqpu5tWfhIcKQ4PWo9KexL X-Received: by 2002:a17:902:7883:: with SMTP id q3mr1126223pll.89.1559180678979; Wed, 29 May 2019 18:44:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559180678; cv=none; d=google.com; s=arc-20160816; b=VzyDC1kiIQEpo+0sNyIfkBM/WoV2spx3s/LePbjo8F1KksdUoPRDzJlr78J0RMg9ch C01TmhB1egOGup7I84E096vRJ1jnmlsnEIDrYfZQ0MHgeRVE/mu8Uw38ZasN1UHMilwT l6Ab2Z8To9vKBwNj+xtvnpNeoU5eV0Kb7v9wpcirKawR+EhjTuTDitUZQ7zy3ilijfxS CSsT7RIO9MG8e2mqrfFKSMVI8mxm655PhXvXZltG8c5RHIKKuFLK2uyjzaMVjyNvfY10 D23TRpwpbWAf71TDksirmkKW8/8HIgXDOUPfQjEizixTOi3sE+d9bORKqBCf1EcFv1nE vLvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=Pjb0boqwhTohB5CBxIww2RHM4T6rpUs5ByWOgMxA14A=; b=JalZnLSdGviY2TRveXpszeSTruWR1fZ6HbTQXzM6gAtkscFQR6cCAnmVqKmuR/TFRV 3RrgpUfJ6mx649YDiggY5Qf35TSDLYgQjd3Juj+CXN4kFoGYHWqN/SzpFxcvxrIgCZso AQpRGM57R+9nBYjROQuGPS/AC6i5MObWwR8zeol8eIK/K9+CcnHkvX2dPSOtbZ/jKq5w zxsqJKu+uT6Nb0FcFV3XKn9hmV/THyrIj6RzAydhUHCfbmHIBSjLnEo/Peohc81MqA/c 0B1GCgAj2sJ3+9w/h7VkaYRx8pujLRC0SOtb6n+stkEt6KCDK9dgmkQw6b5ruYMfbkf7 gyUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=i1pyhqTE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x13si1405329pgi.165.2019.05.29.18.44.22; Wed, 29 May 2019 18:44:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=i1pyhqTE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727345AbfE3BmC (ORCPT + 99 others); Wed, 29 May 2019 21:42:02 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:52162 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbfE3BmC (ORCPT ); Wed, 29 May 2019 21:42:02 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U1d0Ba163161; Thu, 30 May 2019 01:41:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=Pjb0boqwhTohB5CBxIww2RHM4T6rpUs5ByWOgMxA14A=; b=i1pyhqTEk9+RgzRoTyJW05yH7bUu4ol9s1bBaotXN1OuiwDlLSCfrzkniJYP6QqEbq5h QjhsrfsUkRQDwXmUUyveLNXAKrehEVKwYsS52wEzXx6I+QFYJ0Nv3TBw+A5Yd5t3OP+x 9De6NirKMjseFgN88SoBd5H6BHGdFLWipTeksf3mVkS09zkbdIZ+HID12aeu8XpzmyKy h6SHA9RwbYvMccGwmelptsyaY/vEpDq7GIbj0KoHFOknOSOkTCNGJ2Kx/xA9GewMiJRF tBiqB6Jl5jrD7qIdR2phJlKdRPAcOPlpYNq38Ln7HpW4za/kbPofRWr/4kpGxgxyytk3 8A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2spw4tn9d6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 01:41:56 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U1fNeo085043; Thu, 30 May 2019 01:41:56 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2ss1fnss91-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 01:41:56 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4U1ft5l008704; Thu, 30 May 2019 01:41:55 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 May 2019 18:41:54 -0700 To: Hariprasad Kelam Cc: ddiss@suse.de, "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] target/iscsi: fix possible condition with no effect (if == else) From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190528012151.GA4845@hari-Inspiron-1545> Date: Wed, 29 May 2019 21:41:52 -0400 In-Reply-To: <20190528012151.GA4845@hari-Inspiron-1545> (Hariprasad Kelam's message of "Tue, 28 May 2019 06:51:52 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=841 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300011 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=895 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300011 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hariprasad, > fix below warning reported by coccicheck > > drivers/target/iscsi/iscsi_target_nego.c:175:6-8: WARNING: possible > condition with no effect (if == else) Applied to 5.3/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering