Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp169872ybi; Wed, 29 May 2019 18:57:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxVyzGm+kClCRavtzNa5mGr19DhZVMLeQ6eTGvbMzCJP2cjOqWskhW15ZssxYIP0T1cdpl X-Received: by 2002:a63:c50c:: with SMTP id f12mr1213339pgd.71.1559181448572; Wed, 29 May 2019 18:57:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559181448; cv=none; d=google.com; s=arc-20160816; b=Ew8/Zag0EHQm3DQTa+V3nTGhMG7OZ0ArFUJXwxdOSC0JMKOuno65HGK6fzi9OELTWN An19HvO2LMUf2if7rYpkIx+W8mto9kxAVb3zeKF4llh6m5A5HhbIV2Ut7upF4pm+CPFD xLe1SmJsaNIKMGyyXBwxIvFnhoKdKZdozrg0Vl1/wTynN3w9DB/uKH0jD4a+oaK0axT/ PtYo/CMRlq8H8cba7WTVzqBE9K4WxkwbhzmcsdBZjmyeQjqw9i0qzp1DHX2k1E8GKVN1 4TN6ItbSyzyF0V1i9vVGtSmrEJiOgkWcy6YW1Wi0LEMHgywr/iDPaaGs0cSRxQV1eto+ HWyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=ZjKKzHfOfna8qYGAb871hsk+79NOFRAlLLraLjx7BJY=; b=oG1sXd5XtRN/FlLoztluzhSeUPlukUKEA1Ak+nLPtiCVfXwmv1rj7NFqUctX2755vo E4faI14bW5qcjyA6EVt2zPZNQHOBAExBbDo6IJpPZZfaAHmOBaRQVT41dhD2QrPhudHo LObGaiz4ieffFfpnIjdFvoslRLLVQ78ZK0Zz/vlc4XJOSUyeYqCap2kEXID+yKoi7tAJ q7X3ZWTrw7crVn3fhjx6OUXTevEvxI0sPMPzjtldav9VFPU1u4qy/st6L9p7DJPeR8dK lTdvcYNU9xv0RoHtUPAQw9qj6JK+groKweOzLgk7Q5ZdCFUiBNDVPLHZr74T3C7sDnKS JMHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=vn264UWd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si1739846plu.126.2019.05.29.18.57.13; Wed, 29 May 2019 18:57:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=vn264UWd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbfE3Bzw (ORCPT + 99 others); Wed, 29 May 2019 21:55:52 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:34514 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbfE3Bzw (ORCPT ); Wed, 29 May 2019 21:55:52 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U1rrtq172668; Thu, 30 May 2019 01:55:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=ZjKKzHfOfna8qYGAb871hsk+79NOFRAlLLraLjx7BJY=; b=vn264UWd5JiGrQ530KfwSfvuniLAOFL0t2SyOV+R6LnrjwthAOwJ7GetJoSLQycRVqXA tPL4GXhvlhw8E7LmZX9niW5QNMVY8bFtW1KU7/ogu3NC2gYvkq0SLz+ZnU069E/pFh/2 R7uP9wzsWrEznVO5sAnBn+55X2uxqYiWHYxUvgXGxWin2lbCEitXQGzbmLDYukNNAYeC NISfj/nb17FFO9ynie58jadA+nSmnpCJ231/WR0AnL8sGZE4gPA+KVBZRbfa+Of/yE6j l8wTgH6vVPSueu6qjTCwMa5kE1LNDKMZSxuG2gyIWvKsrbWQY+vAGSioAFvtv2o06GWF pA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2spw4tnabc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 01:55:47 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U1tkZV109125; Thu, 30 May 2019 01:55:46 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2ss1fnsw2j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 01:55:46 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4U1tia8015871; Thu, 30 May 2019 01:55:44 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 May 2019 18:55:44 -0700 To: Colin King Cc: Don Brace , "James E . J . Bottomley" , "Martin K . Petersen" , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190522083903.18849-1-colin.king@canonical.com> Date: Wed, 29 May 2019 21:55:42 -0400 In-Reply-To: <20190522083903.18849-1-colin.king@canonical.com> (Colin King's message of "Wed, 22 May 2019 09:39:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=931 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300013 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=987 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Currently the check for a lockup_detected failure exits via the label > return_reset_status that reads and dereferences an uninitialized > pointer dev. Fix this by ensuring dev is inintialized to null. Applied to 5.3/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering