Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp184127ybi; Wed, 29 May 2019 19:15:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrVjPsvKEXG4V73KZBR4S/98sKg3k201wzCy5zjNofX93H+Bqp4S+T4JdBbU+yunHwRQGi X-Received: by 2002:a62:2706:: with SMTP id n6mr1051502pfn.150.1559182513155; Wed, 29 May 2019 19:15:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559182513; cv=none; d=google.com; s=arc-20160816; b=ibWGSKUoKMNF/gIgm6gtZ2ZUJ1/PgljHYWnDVB4hHooGGj69CBL+lxx9khlNS3nTNf pruLcgvcCHDdc4TJoEIeWxlorVhg7C1AHsTBBGUGiuwgU4YHM/hjLCjOjzAwIOzh9Ci1 CBkDKCpFxRqhfx4wJZonZ8YFvf0MFMsSjOQiin0XC9d4mY5Lk6CNyVJG1xI9rPwQ5yeF 3czcv5e2MvO322nscX1+06+Br6h332dXQZv3itTWP6aWI+FUZ88xIngwSkQCu8xvkTAq tV10JR8m2VihoS+RsM1fE8kfi8vlS5boPARp7UKnNMusHfmctBXxI3YetmsAGHeeAxU0 8bvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=TK4HxiyT84v3DfXzv3Ghgl6nVzJVOQ1vSjKsSf7Y7OE=; b=fDulo3bXMmT3gyD3AgDAsdUNY+hIaD9JYZxufC8ZkxUuWpWKekoWWexcx89TO5XVoN oFEJVoM2f22is89dwfV/l61WE1YofWjldtCi3zK1IyJ5oIB5l7uSuXt+gjuTRV5/BQdo yZKW+iNRjYNRqbcXDRHyLLLkoVTIlvWhGfJQoMXT7i8Eb8RgHUiJg5S1vRKuWYWC32gN s6NL8oHmAXR9QJVPrrZviPnC9uiH4i+7Zbgf1ia9GRY329nd/K60Mfdfsgi0qpDdt0QJ 0gNNVab2M2HaCXTDNV8XYV3qi319xOl9FmdPunCgiq8YsbvL9NVhULdYhH2L4wV4UrSD QyZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="Wl6p/gtZ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j3si1557008pgh.445.2019.05.29.19.14.55; Wed, 29 May 2019 19:15:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="Wl6p/gtZ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbfE3CMC (ORCPT + 99 others); Wed, 29 May 2019 22:12:02 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:46766 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbfE3CMC (ORCPT ); Wed, 29 May 2019 22:12:02 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U2A3ZL183552; Thu, 30 May 2019 02:11:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=TK4HxiyT84v3DfXzv3Ghgl6nVzJVOQ1vSjKsSf7Y7OE=; b=Wl6p/gtZSzx1hdyVhn9C9JTVr20EFddGGd1t47OCeKJl6XjQgquYXgQVV3Tr1w6uYhMR ZG8OcbJz208Kymyamche4saBYSfGX5sMYJdd7mKh/zJe8sUQo/Qq30DtzE3VX+Q4BAhs PU0mCVQqaMQ/V8vobM/jBlEJmrkkwkZHnc/UxhiyKjuQklony61Pc64PQQiGY8N2mRK7 hlxhJJj3GbiAyO4RuGhyaKpr8uDSkNNEAzaTE6YESMImZubNRngCbAoLfKrPiqYAhRae QTTMzJlcUHnqJWTGuleeNfK2v0bFYgilNLBm2fS8TE6sb40+AkLN0Jow0TO4MAyCNX6V tQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2spw4tnbk1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 02:11:44 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U2BMa6139401; Thu, 30 May 2019 02:11:43 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2ss1fnt2dt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 02:11:43 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4U2BgQn022351; Thu, 30 May 2019 02:11:42 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 May 2019 19:11:41 -0700 To: Jason Yan Cc: , , , , , , , , , , , , Subject: Re: [PATCH v2] scsi: libsas: no need to join wide port again in sas_ex_discover_dev() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190520140600.22861-1-yanaijie@huawei.com> Date: Wed, 29 May 2019 22:11:38 -0400 In-Reply-To: <20190520140600.22861-1-yanaijie@huawei.com> (Jason Yan's message of "Mon, 20 May 2019 22:06:00 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=841 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300015 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=883 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300015 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason, > Since we are processing events synchronously now, the second call of > sas_ex_join_wide_port() in sas_ex_discover_dev() is not needed. There > will be no races with other works in disco workqueue. So remove the > second sas_ex_join_wide_port(). Applied to 5.3/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering