Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp194457ybi; Wed, 29 May 2019 19:28:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRLpxnH3mH+d/pef0Fkv3eqoczp9wNhuYZgieFapw+ri+nk35b8Op7l8ZduMiHBftozP6w X-Received: by 2002:a65:5004:: with SMTP id f4mr1428419pgo.268.1559183317804; Wed, 29 May 2019 19:28:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559183317; cv=none; d=google.com; s=arc-20160816; b=vQa47boAyz9ftdqiaUOfqedhG6qMUglBrvdHp36PAWzbsvgY+YUoxvoQqcHUkeRZDd HeIwnA8I71l4h6+1ihgRWeC4uAMGA4dU768c/mZsKjalY2tDS2z5pizfH236oA6lyzEF /o4BQuFzytaxbN/JvBULITTA2hY4fFu/lN0SKkz8Q8D/CUQzf/SZyNWrgDi1P7HxfPAq hO8Phj1sLWbAxGYP1J4cb4cmA255Fs1vomK+GZPgOfxXlkRT0d9MT1EuprF054xvbFQx wMTmvLy6AdC/90/t/67j4EyngCBDq5jTp45lRFlsPrZRd8Xp2puVeC9IMvZZaeOxHqSW Lncg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=pde1tJSDf/v1dzfrUCyTZ0Ne/TcdCmJiYYuCRbdaaAQ=; b=FudCojsxx164tQD3Wh6oySpW1hzk4VxZkWMFBvfmHijFI9zRQOsUOh3pvmNB//Y28q Jt5GPs6XAEaavBQENVepwW8NbMuax/eEGvnA8lOSzq83keAMn9bRM4UCSKWCflZn0el6 JcO1620Pz6jYYvpazeq63AnG2xr3KuBddKLeDNK3vN1IvM2ZKgO5IH/wL7sm6tpzNRO/ GLw/ve4zcd8j4lsNjyMV0dgEYA4AUIcv4ZgQketFZSfLrIcSWbXoCSPiCJRlNtgw/w8r 71eW3b2h5dCLywceb2fTcj2hHUUHFlnbcZ2bPbcnKg44HdViCPLgHxDgst9zRbEck0eC fU4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cXbde7oR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j23si1708766pff.159.2019.05.29.19.28.20; Wed, 29 May 2019 19:28:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cXbde7oR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727388AbfE3C0C (ORCPT + 99 others); Wed, 29 May 2019 22:26:02 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:58838 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbfE3C0C (ORCPT ); Wed, 29 May 2019 22:26:02 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U2J2nD189689; Thu, 30 May 2019 02:25:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=pde1tJSDf/v1dzfrUCyTZ0Ne/TcdCmJiYYuCRbdaaAQ=; b=cXbde7oRdJt6u90rdLxDmer2J5AEPQycaNk0wR0vltLLTu/cLIpqATRvGO/VA+ulx0Qi 6E5f9PQtG1P6yFoiaprk3quvn5frTLhbwUn4nRG/Gbtu1Q7Q5lvziZS//oO9euhtHeir gD6rVpzc9eP1iaLSlpNQCPr88MFJ2uGWpT1BEowOdur6cH/YuF0iEN++belLZOQHulai py5AtydfdfZJNIxO88EVLboP2jVpWPq5xwJmql3v+YamjAklqGgWplCfJFOSCKWBmTYh pgf6QPWlw49X7xKYsGOWWPZmo1cHnQIii+zTynTqIGmyWvMufk9YEPjAtZ/isZcP32LU yQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2spw4tnd7y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 02:25:55 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U2O2uZ032937; Thu, 30 May 2019 02:25:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2sr31vkqjc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 02:25:54 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4U2PrOk014617; Thu, 30 May 2019 02:25:53 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 May 2019 19:25:53 -0700 To: YueHaibing Cc: , , , , , , , Subject: Re: [PATCH -next] scsi: megaraid_sas: remove set but not used variables 'host' and 'wait_time' From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190525124202.8120-1-yuehaibing@huawei.com> Date: Wed, 29 May 2019 22:25:50 -0400 In-Reply-To: <20190525124202.8120-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Sat, 25 May 2019 20:42:02 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=954 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300016 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=991 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300016 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warnings: > > drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_suspend: > drivers/scsi/megaraid/megaraid_sas_base.c:7269:20: warning: variable host set but not used [-Wunused-but-set-variable] > drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_aen_polling: > drivers/scsi/megaraid/megaraid_sas_base.c:8397:15: warning: variable wait_time set but not used [-Wunused-but-set-variable] > > 'host' is never used since introduction in > commit 31ea7088974c ("[SCSI] megaraid_sas: add hibernation support") > > 'wait_time' is not used since commit > 11c71cb4ab7c ("megaraid_sas: Do not allow PCI access during OCR") Applied to 5.3/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering