Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp216753ybi; Wed, 29 May 2019 19:58:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqybSLoWmPTPBwBM9Squ60raRmDddFtfO/bXhbnjrcy1oMGLzqjfJOKKxcQDmH84NqkTB06m X-Received: by 2002:a65:5244:: with SMTP id q4mr1513044pgp.79.1559185086087; Wed, 29 May 2019 19:58:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559185086; cv=none; d=google.com; s=arc-20160816; b=c36PiJf0wM2pxj74hdDXMwIjPp+Zxgcwotyrci0/crb2SvNJgjjy3KwoslrTo7b2gN O1iaUpR6Te02cZ2G1Ue8X59erGUTPwx4Qf/KDgQuFbTMvBLeRqIDIlfjw0v0g4zl9qK2 mehZlH2P5tHoleckoAUKajglDTzjcLpTX6kGDgsmNDqAEM3AboW2+bDmq839OsE9P0cF zc1TGH+gA4TOfK9QHaUwa0vJyPoHMllRxUm96FgXq30W/zEKxG2zEhuVUaA4ldWf5LA6 Ry33bGzIm67ekEbR6Jcg00r9T1DycMwXykolVAQuxtw571zlZ6DngO9Huj8sHdOdRIIR r5aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IryhIRAluN0UnomwvxkbYxdPEqGdg0Oi5OVTWudGcpM=; b=uA3fbrtASrYbWuw2W3WSNdo6WEfGDETOUGs2xWM3feQhAgrVMJJnkgFkbnIXT1NExB SR2bROb+oan6sxgepeDufQ38vNAr6zXOma3j+WgPUKqnVo+Dq5FEtaXZrmdQISYVTPYG hUd4e8aSKgV9li9BUqqlWzwR5MCQDCO/9Q6p9Qsd1lCERtJDfXNV/3XvW39oVdpNy9QW NEgQf1Ez9BtF7WQI266CEYSKKjFNeWalNVUc/0Ifk5tYgaA1AsKOl+OeQfCRWQ8MUkz7 MIHHh+DlvFIvoTClVsvvvS9lHgcobMqCS6d44CwQ1g5zbxDvK/W3gUMM8x+EmnQts7Sv K6lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=HxRm98xT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si1635376pll.254.2019.05.29.19.57.36; Wed, 29 May 2019 19:58:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=HxRm98xT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727477AbfE3C4P (ORCPT + 99 others); Wed, 29 May 2019 22:56:15 -0400 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:2423 "EHLO smtp-fw-4101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfE3C4O (ORCPT ); Wed, 29 May 2019 22:56:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1559184974; x=1590720974; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IryhIRAluN0UnomwvxkbYxdPEqGdg0Oi5OVTWudGcpM=; b=HxRm98xT5YYSlHMw7NJsIzIwDbRppO/P12XpWAfqDXUSY/3cLqsLmie8 tIbkKCgv52UjnrgNQL1MSXpAESVnB2tgLF7Va5mnDlOaa/zaLHBMdfg9G fk8QSB8fS3Jr/tf42uxVlaAiFcem5ZATDd0NzVgP+dWdgIKNOS76O7lw2 g=; X-IronPort-AV: E=Sophos;i="5.60,529,1549929600"; d="scan'208";a="768210708" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2b-8cc5d68b.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 30 May 2019 02:56:11 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-8cc5d68b.us-west-2.amazon.com (Postfix) with ESMTPS id A51B6A2156; Thu, 30 May 2019 02:56:10 +0000 (UTC) Received: from EX13D05UWB002.ant.amazon.com (10.43.161.50) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 30 May 2019 02:56:10 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D05UWB002.ant.amazon.com (10.43.161.50) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 30 May 2019 02:56:09 +0000 Received: from localhost (10.94.220.85) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 30 May 2019 02:56:10 +0000 From: Eduardo Valentin To: Guenter Roeck CC: Eduardo Valentin , , , Jean Delvare Subject: [PATCHv2 0/2] hwmon: couple of fixes on HWMON_C_REGISTER_TZ Date: Wed, 29 May 2019 19:56:03 -0700 Message-ID: <20190530025605.3698-1-eduval@amazon.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Guenter, I found these bugs in the error path of hwmon_device_register(). One related to calling of-thermal when no dev->of_node is present. And another in the error path handling of it. Only difference from V1 is that I changed patch 2/2 to remove the device_unregister() before jumping into the new label. Eduardo Valentin (2): hwmon: core: add thermal sensors only if dev->of_node is present hwmon: core: fix potential memory leak in *hwmon_device_register* drivers/hwmon/hwmon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.21.0