Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp246058ybi; Wed, 29 May 2019 20:33:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZ4cjoRaHnEj97oqtRrstV9sJ8Ub3GE9KRG9PO4O+moVGnHcocAX1PKt+ByQEWEO+oddE/ X-Received: by 2002:a63:1b07:: with SMTP id b7mr1655851pgb.289.1559187225783; Wed, 29 May 2019 20:33:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559187225; cv=none; d=google.com; s=arc-20160816; b=G3xE4U7tHhDvh6mVHhlYAKpcluYF70e6fIbVVJk33Tv67upa1aHW7/RrsOXoqT+dsj 4a7IrE4znCKtawjkJCYAJghrZLD0L1Ew4CJ2ZQ7DT7Ie9Fc9M0WFw+eQErio6viWvQx7 vBOFWYSxw0opeRGh5dsNuNaPa4ypEFARoxuaXCrBYkgB9E61TjAswEbezgKD17f8n8if 11ec9o/PY5j0VCg/fr0a6LWzArhVgfTAXE7SL/PqCrESpN90ISJ8W8XIo+yvhNq5mRw7 0Qqyj5hLVnIUf8xW55z62SPhiZuDfsWLTIqJFICbqug76KLQP1yNp3PtkkeDwZ3tJkhl DQGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XNgpG141ZRQsDWtKYHWcGpQOODMpt+BgdrwJ0cjakIg=; b=wm2YxqP5jzQQbSI5lJZKeWZystG/XT+Yx46D3xk5Ew0CDzUN5pnW0xcyISFhSUIooP VIzIG4MDJXBk6Fc3vqTC+KZ4hV1IRB/u+TciP5KkM2t1rcUapq/MdH3rZszhDcKT4igJ 9oao+0IGi83hbgtdZbu9/4H+mEeuqhPat7XcLjYbMKCiSrzPCJI/KwBH1Am7Y5VTS1EY 4a2FG+0kAAzXWRe1u7+TmsFY445pUrkf6/JN0/KphPDlmWrBFx0AOKTKJkkkxsf9dm/G l2eQN6utkdYi8pscgr3kNyRzwUJBw7128+Cx2mv5XxgCHJcwP6F25fB0rJvt/SGJya8x dBuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VHFMTvJz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r2si2190823pjb.0.2019.05.29.20.33.29; Wed, 29 May 2019 20:33:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VHFMTvJz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388406AbfE3D3e (ORCPT + 99 others); Wed, 29 May 2019 23:29:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:59786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732316AbfE3DUp (ORCPT ); Wed, 29 May 2019 23:20:45 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 847722492F; Thu, 30 May 2019 03:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186444; bh=cljvCdreLiATqOX+yPWqpwvNf0F2rEkzn8uzKx7ndVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VHFMTvJz5TBSyR4eGSG332svgfuj0dsjZVhGY0xeM59t9zQIX1g/yEPtyzc0qZF6y oN7gzTbilh6dH8q+M8y+CfLd2QXIkQ6r47LuPI/oiY/SavEbKJWqBH9o9qOiRPqYV1 TtkotPQnxfY4QXVuTa3cNKiNN4A5r0bEdhn6CNvg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kees Cook , Borislav Petkov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Sasha Levin , Sami Tolvanen Subject: [PATCH 4.9 050/128] x86/build: Move _etext to actual end of .text Date: Wed, 29 May 2019 20:06:22 -0700 Message-Id: <20190530030443.771931522@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030432.977908967@linuxfoundation.org> References: <20190530030432.977908967@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 392bef709659abea614abfe53cf228e7a59876a4 ] When building x86 with Clang LTO and CFI, CFI jump regions are automatically added to the end of the .text section late in linking. As a result, the _etext position was being labelled before the appended jump regions, causing confusion about where the boundaries of the executable region actually are in the running kernel, and broke at least the fault injection code. This moves the _etext mark to outside (and immediately after) the .text area, as it already the case on other architectures (e.g. arm64, arm). Reported-and-tested-by: Sami Tolvanen Signed-off-by: Kees Cook Cc: Borislav Petkov Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20190423183827.GA4012@beast Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- arch/x86/kernel/vmlinux.lds.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S index 55f04875293fa..51b772f9d886a 100644 --- a/arch/x86/kernel/vmlinux.lds.S +++ b/arch/x86/kernel/vmlinux.lds.S @@ -111,11 +111,11 @@ SECTIONS *(.text.__x86.indirect_thunk) __indirect_thunk_end = .; #endif - - /* End of text section */ - _etext = .; } :text = 0x9090 + /* End of text section */ + _etext = .; + NOTES :text :note EXCEPTION_TABLE(16) :text = 0x9090 -- 2.20.1