Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp246289ybi; Wed, 29 May 2019 20:34:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOb74uT9MDZMHwii4T0YwR1n6+Tca89go682AMi8iRNqU2K9vTZjSlyhIMg6TtBSQun0xc X-Received: by 2002:a63:2355:: with SMTP id u21mr925006pgm.205.1559187242317; Wed, 29 May 2019 20:34:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559187242; cv=none; d=google.com; s=arc-20160816; b=IGASnNvPRCCPP7FTXDo7STXVrVOaIGdV0bU3iGzrbSdKG2vOalx+iGF6KZE94Sspjf oxa6khNF41riOi0LiyamHZ9XH9GJaP2eteKaU9Rfq9HLgWAict8VtHZRKORiKw6qHWtS r5mCfmYlGBC2Gty219WUhfnudihqSgcCJz1lGM2+7jd8mDQq5dsy6ULbamRDh/ZPh/6P xlnI2xQFhj9woTncJoHRH/UweglEiy46EPY8wIgEi5Xsia8ofS619MSR+UNbwd6ssgal 7iej26UpGBkVjWtwVK/VEwhpXAaWgXH3JYqbd6op55BJppl1y8XBcRyFFhvzqUB2Gvtb M6MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ClwytLeUF4WVfMeLlTzQ2mXGyTdVgc/4ZTlonxjTGjQ=; b=wrkbBqa2MWSMni3RasVkzkIlfih7d1Y5amX2yS2v3N1kYQGHjkh6k/qGsllW4zYp6D wblaagUvVBJ7KqxpgVcEdHhBBADUnooJypeOX/ehPDoVq02OuQV9hqutnrqIdhHbGP7n KNgKelMVOV6lsyN+61p8ytZG3djAaSRVbvy0JCaIYCmG3eDu6e96frqg0eQgn2vjBdVM UZNWKSCtsXK5I+c/KM4FlHFVJ6hEKewEaxQ8+L2HccQZc/S/b1Uhw2UiQ9K3jjBZkTsJ Vih+KOHQX2dLE/vQrNRYdxwW9AzchypzrR/z9Byr3ODalqKwf107ZkVciAgfVsfZ9oVp Orvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="KsKmS/tX"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si1633656pjs.96.2019.05.29.20.33.45; Wed, 29 May 2019 20:34:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="KsKmS/tX"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388343AbfE3D3T (ORCPT + 99 others); Wed, 29 May 2019 23:29:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732252AbfE3DUe (ORCPT ); Wed, 29 May 2019 23:20:34 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2256D248F2; Thu, 30 May 2019 03:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186434; bh=UT5ptIzvBWmArzRHvLDDWZswCaWyxEW9/R4B4KcsSDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KsKmS/tXs2Ix+U77Uchr61h0bFWKmf3s5aJmvVn1qVMOY14/qAB7x21QwE+n+qjs6 HZ6WnQPqGooQX/0CB5LstXA4qXOdv9DYGmWaVwsAKd9Y0jBZP8XgI7oXW7ZJeuvvXP Conm6Rt+4O9FzRhPCPIbqbwhL0QAPXyQpIAuM4Gs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bo YU , Michael Ellerman , Sasha Levin Subject: [PATCH 4.9 029/128] powerpc/boot: Fix missing check of lseek() return value Date: Wed, 29 May 2019 20:06:01 -0700 Message-Id: <20190530030439.845592911@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030432.977908967@linuxfoundation.org> References: <20190530030432.977908967@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5d085ec04a000fefb5182d3b03ee46ca96d8389b ] This is detected by Coverity scan: CID: 1440481 Signed-off-by: Bo YU Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/boot/addnote.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot/addnote.c index 9d9f6f334d3cc..3da3e2b1b51bc 100644 --- a/arch/powerpc/boot/addnote.c +++ b/arch/powerpc/boot/addnote.c @@ -223,7 +223,11 @@ main(int ac, char **av) PUT_16(E_PHNUM, np + 2); /* write back */ - lseek(fd, (long) 0, SEEK_SET); + i = lseek(fd, (long) 0, SEEK_SET); + if (i < 0) { + perror("lseek"); + exit(1); + } i = write(fd, buf, n); if (i < 0) { perror("write"); -- 2.20.1